Change protocol strings to enum values in parsing Protocol options #12135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12135 +/- ##
============================================
- Coverage 17.56% 17.55% -0.01%
+ Complexity 15538 15537 -1
============================================
Files 5912 5912
Lines 529383 529383
Branches 64660 64660
============================================
- Hits 92984 92956 -28
- Misses 425941 425968 +27
- Partials 10458 10459 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Attyuttam
changed the title
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
some alternative (just for consideration)
| private Protocol parseOptions(String[] args) { | ||
| String protocolName = (args.length > 0) ? args[0] : ""; | ||
| Protocol protocol = Protocol.NONE; | ||
| Protocol protocol; |
Contributor
There was a problem hiding this comment.
Suggested change
| Protocol protocol; | |
| Protocol protocol; | |
| try { | |
| protocol = Protocol.valueOf(protocolName); | |
| } catch (IllegalArgumentException e) { | |
| protocol = Protocol.NONE; | |
| } |
Member
There was a problem hiding this comment.
can use this instead
Protocol protocol = EnumUtils.getEnumIgnoreCase(Protocol.class, protocolName, Protocol.NONE);
btw: no issues with the class, it is not used ...
Comment on lines
305
to
317
| if (protocolName.equals(Protocol.VNC.name().toLowerCase())) { | ||
| protocol = Protocol.VNC; | ||
| options = join(commonOptions, vncOptions); | ||
| } else if (protocolName.equals("rdp")) { | ||
| } else if (protocolName.equals(Protocol.RDP.name().toLowerCase())) { | ||
| protocol = Protocol.RDP; | ||
| options = join(commonOptions, rdpOptions); | ||
| } else if (protocolName.equals("hyperv")) { | ||
| } else if (protocolName.equals(Protocol.HYPERV.name().toLowerCase())) { | ||
| protocol = Protocol.HYPERV; | ||
| options = join(commonOptions, hyperVOptions); | ||
| } else { | ||
| help(); | ||
| return Protocol.NONE; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| switch (protocol) { | |
| case VNC: | |
| options = join(commonOptions, vncOptions); | |
| break; | |
| case RDP: | |
| options = join(commonOptions, rdpOptions); | |
| break; | |
| case HYPERV: | |
| options = join(commonOptions, hyperVOptions); | |
| break; | |
| case NONE: | |
| help(); | |
| return Protocol.NONE; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Fixes: #11821
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?