-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: allow viewing hosts from management server connected agents #12149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.22
Are you sure you want to change the base?
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12149 +/- ##
=========================================
Coverage 17.55% 17.56%
- Complexity 15536 15544 +8
=========================================
Files 5909 5910 +1
Lines 529118 529123 +5
Branches 64627 64627
=========================================
+ Hits 92902 92914 +12
+ Misses 425761 425757 -4
+ Partials 10455 10452 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@shwstppr , the needs-functional-definition is because it shows hosts and not SVMs, right? I think we can handle this with a hover-text hint. If this is not desired (user input required) we should just remove the link. |
|
@DaanHoogland the problem is, API/UI will return say 4 agentscount but of these 4, 2 will be hypervisor host agents and 2 system VM agents. If I add a link for either the hosts view or the system VMs view, it can be confusing. Currently, we don't have a combined view for agents' list |
yes, and I see the need to deal with that, but I think for now we can remove any link or just leave as is (within this PR). We do have to create a new issue and maybe even a design discussion. I feel it should not block this fix. /me creating an issue for it. |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
works in ui |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Description
Clicking Number of connected agents shows list of connected hosts for the management server.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?