Skip to content

Conversation

@weizhouapache
Copy link
Member

Description

This PR fixes #12042

No idea how to reproduce the issue. However, 2 users have faced the same issue which seems to be caused by missing {SHA-512} algorithm of checksum value.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.22.1 milestone Nov 28, 2025
@weizhouapache weizhouapache linked an issue Nov 28, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (e23c7ef) to head (97424f2).
⚠️ Report is 1 commits behind head on 4.22.

Files with missing lines Patch % Lines
...apache/cloudstack/utils/security/DigestHelper.java 0.00% 11 Missing ⚠️
...om/cloud/upgrade/SystemVmTemplateRegistration.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #12165   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15545    15547    +2     
=========================================
  Files          5910     5910           
  Lines        529123   529134   +11     
  Branches      64627    64629    +2     
=========================================
+ Hits          92937    92950   +13     
+ Misses       425733   425730    -3     
- Partials      10453    10454    +1     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15859

@weizhouapache
Copy link
Member Author

@blueorangutan test keepEnv

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-14887)

@weizhouapache
Copy link
Member Author

@blueorangutan test keepEnv

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14889)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53254 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12165-t14889-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloudstack 4.22 upgrade: SystemVM template update fails

3 participants