Removed .pydevproject from plugin kvm hypervisor.#1226
Merged
asfgit merged 1 commit intoapache:masterfrom Jan 17, 2016
Merged
Conversation
Contributor
|
No idea why that is in there indeed. LGTM Is just a metadata file, never touched by packaging either. |
asfgit
pushed a commit
that referenced
this pull request
Dec 12, 2015
Show actual diff in commits after merge with git-pr / git-fwd-mergeThis shows the diff in commits after using `git-pr` and `git-fwd-merge` tools, like this: ``` 44e8c92 Merge pull request #1226 from borisroman/CLOUDSTACK-9148 0554610 Removed .pydevproject from plugin kvm hypervisor. ``` That helps in quickly seeing what change is applied and whether it makes sense. It doesn't touch the actual code base. I'm using this patch for some time already. * pr/1227: Show actual diff in commits after merge Signed-off-by: Remi Bergsma <github@remi.nl>
Contributor
Author
|
Environment
Integration test suite 1 Result test suite 1 Integration test suite 2 Result test suite 2 |
Contributor
|
LGTM, is it in .gitignore? it should |
0554610 to
223e3d5
Compare
Contributor
Author
|
@DaanHoogland It's already in .gitignore, I think these we're never removed... |
Member
|
LGTM, not sure why they exist or if anyone (still) uses them. |
asfgit
pushed a commit
that referenced
this pull request
Jan 17, 2016
Removed .pydevproject from plugin kvm hypervisor.Ping @wido @wilderrodrigues @remibergsma @miguelaferreira It's there for no apparent reason... Running integration tests now. ``` [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 6:12.189s [INFO] Finished at: Sat Dec 12 02:13:01 CET 2015 [INFO] Final Memory: 102M/808M [INFO] ------------------------------------------------------------------------ ``` * pr/1226: Removed .pydevproject from plugin kvm hypervisor. Signed-off-by: Remi Bergsma <github@remi.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ping @wido @wilderrodrigues @remibergsma @miguelaferreira
It's there for no apparent reason...
Running integration tests now.