-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add the procedure files for insert extensions and update guest os category #12482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.22
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds new SQL stored procedures for managing extensions and guest OS categories in the CloudStack database schema. The procedures provide reusable database operations for inserting extensions, updating guest OS categories, and managing related details.
Changes:
- Added procedures for inserting extensions and their associated details/custom actions
- Added procedures for updating and managing guest OS categories
- All procedures include idempotency checks to prevent duplicate entries
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| cloud.update_new_and_delete_old_category_for_guest_os.sql | Adds procedure to migrate guest OS entries from one category to another and soft-delete the old category |
| cloud.update_category_for_guest_oses.sql | Adds procedure to update guest OS entries to a new category based on display name matching |
| cloud.insert_extension_if_not_exists.sql | Adds procedure to insert extension records if they don't already exist |
| cloud.insert_extension_detail_if_not_exists.sql | Adds procedure to insert extension detail records if they don't already exist |
| cloud.insert_extension_custom_action_if_not_exists.sql | Adds procedure to insert extension custom action records if they don't already exist |
| cloud.insert_extension_custom_action_details_if_not_exists.sql | Adds procedure to insert extension custom action detail records if they don't already exist |
| cloud.insert_category_if_not_exists.sql | Adds procedure to insert guest OS category records if they don't already exist |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ources/META-INF/db/procedures/cloud.insert_extension_custom_action_details_if_not_exists.sql
Show resolved
Hide resolved
...n/resources/META-INF/db/procedures/cloud.update_new_and_delete_old_category_for_guest_os.sql
Outdated
Show resolved
Hide resolved
...ma/src/main/resources/META-INF/db/procedures/cloud.insert_extension_detail_if_not_exists.sql
Outdated
Show resolved
Hide resolved
engine/schema/src/main/resources/META-INF/db/procedures/cloud.insert_category_if_not_exists.sql
Show resolved
Hide resolved
...ma/src/main/resources/META-INF/db/procedures/cloud.insert_extension_detail_if_not_exists.sql
Show resolved
Hide resolved
...main/resources/META-INF/db/procedures/cloud.insert_extension_custom_action_if_not_exists.sql
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12482 +/- ##
============================================
- Coverage 17.59% 17.59% -0.01%
+ Complexity 15601 15597 -4
============================================
Files 5910 5910
Lines 529819 529818 -1
Branches 64730 64730
============================================
- Hits 93225 93200 -25
- Misses 426099 426124 +25
+ Partials 10495 10494 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, though the co-pilot comments mostly make sense they are not vital.
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16458 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
…update_new_and_delete_old_category_for_guest_os.sql Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@DaanHoogland these procedures (already tested / working ones) are from here - https://github.com/apache/cloudstack/blob/4.22/engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql. ignoring the null validation suggestion there. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16464 |
Description
This PR adds the procedure files for insert extensions and update guestos category.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?