Skip to content

Conversation

@gruckbit
Copy link

@gruckbit gruckbit commented Feb 2, 2026

Description

ACS has the global configuration vm.network.throttling.rate that allows limiting the maximum bandwidth of the default NIC for end-user VMs when it is not defined in compute offerings. However, currently, the setting is static, implying the requirement of restarting the Management Servers after changing its value.
Given this scenario, changes have been applied to make the configuration dynamic. As a consequence, it is not required to restart the Management Servers after each value update; the updated value is automatically considered in the Apache CloudStack internal workflows.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

The default value of vm.network.throttling.rate is 200, and after changing its value to 100 the VM's domain XML presented the following change:

Before:

virsh dumpxml 4 | grep "bandwidth" -A 2
      <bandwidth>
        <inbound average='25000' peak='25000'/>
        <outbound average='25000' peak='25000'/>
      </bandwidth>
      <target dev='vnet10'/>
      <model type='virtio'/>

After:

 virsh dumpxml 5 | grep "bandwidth" -A 2
      <bandwidth>
        <inbound average='12500' peak='12500'/>
        <outbound average='12500' peak='12500'/>
      </bandwidth>
      <target dev='vnet11'/>
      <model type='virtio'/>

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 2, 2026

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@bernardodemarco
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@bernardodemarco bernardodemarco added this to the 4.23.0 milestone Feb 2, 2026
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.89%. Comparing base (7b94ccc) to head (22dc645).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
.../cloud/configuration/ConfigurationManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12567   +/-   ##
=========================================
  Coverage     17.89%   17.89%           
- Complexity    16084    16092    +8     
=========================================
  Files          5936     5936           
  Lines        532635   532734   +99     
  Branches      65148    65165   +17     
=========================================
+ Hits          95298    95351   +53     
- Misses       426667   426707   +40     
- Partials      10670    10676    +6     
Flag Coverage Δ
uitests 3.68% <ø> (+<0.01%) ⬆️
unittests 19.00% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants