backport: default system vm template update implementation

[shwstppr]

Description

Fixes #12934

Backported from 889fc62

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (c19630f) to head (8c84ad4).
⚠️ Report is 5 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...m/cloud/upgrade/dao/DbUpgradeSystemVmTemplate.java	0.00%	10 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12935      +/-   ##
============================================
+ Coverage     16.25%   16.26%   +0.01%     
- Complexity    13415    13434      +19     
============================================
  Files          5664     5665       +1     
  Lines        500465   500530      +65     
  Branches      60780    60787       +7     
============================================
+ Hits          81338    81411      +73     
+ Misses       410031   410028       -3     
+ Partials       9096     9091       -5     

Flag	Coverage Δ
uitests	4.15% <ø> (ø)
unittests	17.11% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

code lgtm

[DaanHoogland]

clgtm

[sudo87]

clgtm

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17315

[RosiKyu]

LGTM

Tested with upgrade from 4.20.0 to 4.20.3. The fix correctly triggers SystemVM template registration on upgrade - the latest available template (4.20.2) is downloaded and new System VMs are created from it.