Fix id in listguestosmapping search

[sureshanaparti]

Description

This PR fix the id passed in listguestosmapping search.

The tests test_CRUD_operations_guest_OS_mapping, test_guest_OS_mapping_check_with_hypervisor in 'test_guest_os.py' are failing with error "Problem with condition: id".

2026-04-28 15:29:45,344 WARN  [c.c.a.d.ParamGenericValidationWorker] (qtp253011924-20:[ctx-c76bda5d, ctx-7d5bf577, ctx-35332a51]) (logid:f1b8b89a) Received unknown parameters for command listGuestOsMapping. Unknown parameters : listall
2026-04-28 15:29:45,345 ERROR [c.c.a.ApiServer] (qtp253011924-20:[ctx-c76bda5d, ctx-7d5bf577, ctx-35332a51]) (logid:f1b8b89a) unhandled exception executing api command: [Ljava.lang.String;@372450db java.lang.RuntimeException: Problem with condition: id
        at com.cloud.utils.db.SearchBase$Condition.toSql(SearchBase.java:521)
        at com.cloud.utils.db.SearchCriteria.getWhereClause(SearchCriteria.java:267)
        at com.cloud.utils.db.SearchCriteria.getWhereClause(SearchCriteria.java:285)
        at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:374)
        at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:369)
        at com.cloud.utils.db.GenericDaoBase.searchAndCount(GenericDaoBase.java:1525)
        at com.cloud.utils.db.GenericDaoBase.searchAndCount(GenericDaoBase.java:1515)
        at jdk.internal.reflect.GeneratedMethodAccessor190.invoke(Unknown Source)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:569)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
        at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
        at jdk.proxy3/jdk.proxy3.$Proxy288.searchAndCount(Unknown Source)
        at com.cloud.server.ManagementServerImpl.listGuestOSMappingByCriteria(ManagementServerImpl.java:3084)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:569)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
        at jdk.proxy3/jdk.proxy3.$Proxy247.listGuestOSMappingByCriteria(Unknown Source)
        at org.apache.cloudstack.api.command.admin.guest.ListGuestOsMappingCmd.execute(ListGuestOsMappingCmd.java:95)
        at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:173)
        at com.cloud.api.ApiServer.queueCommand(ApiServer.java:875)
        at com.cloud.api.ApiServer.handleRequest(ApiServer.java:689)
        at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:417)
        at com.cloud.api.ApiServlet$1.run(ApiServlet.java:194)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.68%. Comparing base (ffebe8e) to head (73b8dfc).

Files with missing lines	Patch %	Lines
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #13082   +/-   ##
=========================================
  Coverage     17.67%   17.68%           
- Complexity    15789    15790    +1     
=========================================
  Files          5922     5922           
  Lines        533094   533094           
  Branches      65210    65210           
=========================================
+ Hits          94246    94259   +13     
+ Misses       428208   428194   -14     
- Partials      10640    10641    +1     

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.75% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17654

[sureshanaparti]

@blueorangutan test ol8 vmware-70u3

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[DaanHoogland]

makes sense and code looks good, but I have no idea about the old code’s validity.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[sureshanaparti]

makes sense and code looks good, but I have no idea about the old code’s validity.

@DaanHoogland It's due to recent change here: #12802, only KVM tests were performed on the PR. These tests (test_CRUD_operations_guest_OS_mapping, test_guest_OS_mapping_check_with_hypervisor) will be executed for VMware, Xen hypervisors only.