Skip to content

Fix listing of resorces for ASG belonging to a project#13187

Open
vishesh92 wants to merge 1 commit into
apache:4.20from
shapeblue:fix-listing-for-asg-in-project
Open

Fix listing of resorces for ASG belonging to a project#13187
vishesh92 wants to merge 1 commit into
apache:4.20from
shapeblue:fix-listing-for-asg-in-project

Conversation

@vishesh92
Copy link
Copy Markdown
Member

Description

This PR fixes #12978

This PR resolves missing project scopes issues within the AutoScale UI components (AutoScaleVmProfile.vue, AutoScaleUpPolicyTab.vue, and AutoScaleDownPolicyTab.vue).

Generated Summary

This pull request improves the handling of project-scoped resources and enhances template name resolution in the AutoScale UI components. The main changes ensure that API requests include the projectid parameter when relevant, and that template names are accurately fetched and displayed, especially when templates may not be present in the local list.

Project-aware API requests:

  • All API calls in AutoScaleDownPolicyTab.vue, AutoScaleUpPolicyTab.vue, and AutoScaleLoadBalancing.vue now include the projectid parameter if the resource is part of a project. This ensures correct data retrieval in multi-project environments. [1] [2] [3] [4] [5] [6] [7] [8]

  • Similar updates in AutoScaleVmProfile.vue add projectid to template, VM profile, and related API requests for project-scoped resources. [1] [2] [3]

Template name resolution improvements:

  • Replaces the previous method of looking up template names from a local list with an API call (listTemplates) to fetch the template name by templateid. If the template is not found, the raw templateid is displayed as a fallback. [1] [2] [3] [4]

UI/UX enhancements:

  • After updating an AutoScale VM profile, the UI now refreshes profile data to reflect changes immediately and closes the modal dialog upon success. [1] [2] [3]
  • Prevents multiple concurrent updates by disabling the update action while loading.

These changes collectively improve the correctness and user experience of the AutoScale UI, especially for users working with project resources.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.26%. Comparing base (a7c2a05) to head (f26cbfe).
⚠️ Report is 1 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #13187      +/-   ##
============================================
- Coverage     16.27%   16.26%   -0.01%     
+ Complexity    13440    13436       -4     
============================================
  Files          5665     5665              
  Lines        500555   500597      +42     
  Branches      60789    60803      +14     
============================================
- Hits          81445    81429      -16     
- Misses       410004   410058      +54     
- Partials       9106     9110       +4     
Flag Coverage Δ
uitests 4.15% <ø> (-0.01%) ⬇️
unittests 17.12% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Template name doesn't show up for AutoScale Instance Groups

2 participants