Fix listing of resorces for ASG belonging to a project#13187
Open
vishesh92 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13187 +/- ##
============================================
- Coverage 16.27% 16.26% -0.01%
+ Complexity 13440 13436 -4
============================================
Files 5665 5665
Lines 500555 500597 +42
Branches 60789 60803 +14
============================================
- Hits 81445 81429 -16
- Misses 410004 410058 +54
- Partials 9106 9110 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #12978
This PR resolves missing project scopes issues within the AutoScale UI components (AutoScaleVmProfile.vue, AutoScaleUpPolicyTab.vue, and AutoScaleDownPolicyTab.vue).
Generated Summary
This pull request improves the handling of project-scoped resources and enhances template name resolution in the AutoScale UI components. The main changes ensure that API requests include the
projectidparameter when relevant, and that template names are accurately fetched and displayed, especially when templates may not be present in the local list.Project-aware API requests:
All API calls in
AutoScaleDownPolicyTab.vue,AutoScaleUpPolicyTab.vue, andAutoScaleLoadBalancing.vuenow include theprojectidparameter if the resource is part of a project. This ensures correct data retrieval in multi-project environments. [1] [2] [3] [4] [5] [6] [7] [8]Similar updates in
AutoScaleVmProfile.vueaddprojectidto template, VM profile, and related API requests for project-scoped resources. [1] [2] [3]Template name resolution improvements:
listTemplates) to fetch the template name bytemplateid. If the template is not found, the rawtemplateidis displayed as a fallback. [1] [2] [3] [4]UI/UX enhancements:
These changes collectively improve the correctness and user experience of the AutoScale UI, especially for users working with project resources.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?