CLOUDSTACK-9905:VPN Gateway with Public Subnet#2086
Conversation
|
Manually tested the change. Steps for defect replication :
After applying the fix, could edit the CIDR successfully. Test LGTM based on manual testing results |
|
We did the same in our fork, works fine. LGTM based on code review. |
|
tag:This is Ready to Merge |
| name = "VPN-" + gatewayIp; | ||
| } | ||
| String guestCidrList = cmd.getGuestCidrList(); | ||
| if (!NetUtils.validateGuestCidrList(guestCidrList)) { |
There was a problem hiding this comment.
@mrunalinikankariya we need to check for the isValidCIDR cidr here. If you look at validateGuestCidr method it is checking for the isValidCIDR first then checking for RFC compliant.
Also please squash the commits into single commit.
There was a problem hiding this comment.
Agree...Will update
There was a problem hiding this comment.
Jayapal,
I have update code accordingly, can you please check
|
LGTM |
6 participants
CLOUDSTACK-9905 : VPN Gateway with Public Subnet
When we attempt to use a /24 subnet with a public IP ranges, for example,153.97.140.0/24. VPN Customer Gateways can be created with this type of CIDR, but cannot be updated, for example to 153.97.181.0/24 . Attempting to do so produces the error "The customer gateway cidr list 153.97.181.0/24 contains invalid guest cidr!"
REPRO STEPS
Created a new VPN Customer Gateway
Attempted to change the CIDR list entry from 153.97.180.0/24 to 153.97.181.0/24
The UI became unresponsive
The Management-server log shows the following:
2017-03-31 17:10:42,471 WARN [c.c.u.n.NetUtils] (API-Job-Executor-9:ctx-ed9b5816 job-172 ctx-32369258) (logid:3a16f24b) cidr 153.97.181.0/24 is not RFC 1918 compliant
153.97.181.0/24
EXPECTED BEHAVIOR
==================
Users should be able to update existing VPN Customer Gateway CIDR list as needed
Resolution
Removed RFC 1918 compliant check during updation of VPN Customer Gateway CIDR