4.11.1.0: Stabilization and blocker/issues fixes #2616

yadvr · 2018-04-30T12:15:26Z

Description

This includes several (smoke) test, stabilization fixes and blocker fixes towards 4.11.1.0 milestone. Please review individually melded commits.
This should be merged when we've near 100% smoke test pass.

Fixed issues list:
#2530 (kvm blocker)
#2561 (xenserver blocker)
#2548 (saml2 blocker)
#2541

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

SystemVM templates used: https://lab.yadav.cloud/systemvmtemplates/4.11/

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Testing
I have added tests to cover my changes.
All relevant new and existing integration tests have passed.
A full integration testsuite with all test that can run on my environment has passed.

borisstoyanov

LGTM, VM migrations should get SKIPPED with hypervisor other than KVM

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

blueorangutan · 2018-05-03T03:02:08Z

Trillian test result (tid-2579)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47627 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2616-t2579-xenserver-65sp1.zip
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

This ensures that certificate setup includes all the IP addresses (v4 and v6) when a (KVM) host is added to CloudStack. This fixes apache#2530. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

On patching, the global cacerts keystore is imported in 'cloud' service specific local keystore. This fixes apache#2541. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This fixes incorrect xenstore-read binary path, this failed systemvm to be patched/started correctly on xenserver. The other fix is to keep the xen-domU flag that may be returned by virt-what. This effect won't change the cmdline being consumed as the mgmt server side (java) code sets the boot args in both xenstore and as pv args. The systemvm's /boot is ext2 that can be booted by PyGrub on both old and recent XenServer versions. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This fixes SAML2 certificate encoding/decoding issue due to refactoring regression introduced in 7ce54bf that did not account for base64 based encoding/decoding. The changes effectively restore the same logic as used in previous versions. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This fixes the issue that post-upgrade egress rules are not applied on VR, restarting the network with cleanup used to be the workaround. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This moves db upgrade paths and checks around a new systemvmtemplate for 4.11.1. The new systemvmtemplate compared to 4.11.0 template is slightly smaller and has meltdown/spectre fixes among few other security fixes from Debian and changes to cloud-early-config. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2018-05-03T08:33:30Z

@blueorangutan package

blueorangutan · 2018-05-03T08:33:49Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-05-03T09:01:49Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1997

yadvr · 2018-05-03T20:31:53Z

@blueorangutan test matrix

blueorangutan · 2018-05-03T20:32:50Z

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2018-05-04T03:28:47Z

Trillian test result (tid-2593)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23174 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2616-t2593-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_site2site_vpn	`Failure`	138.62	test_vpc_vpn.py

blueorangutan · 2018-05-04T04:23:13Z

Trillian test result (tid-2594)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26575 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2616-t2594-vmware-65.zip
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

yadvr · 2018-05-04T07:04:06Z

Test LGTM

yadvr · 2018-05-04T07:04:51Z

@blueorangutan test centos7 xenserver-71

blueorangutan · 2018-05-04T07:05:49Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

yadvr · 2018-05-04T07:07:02Z

Merging this based on 2 code reviews and test results with near 100% smoke test pass, and to allow other PRs to be unblocked from intermittent errors.

yadvr added the Severity:BLOCKER label Apr 30, 2018

yadvr added this to the 4.11.1.0 milestone Apr 30, 2018

yadvr added component:kvm status:testing labels Apr 30, 2018

This was referenced May 1, 2018

agent: import letsencrypt X3 cross signed certificate to ssvm agent keystore #2551

Closed

Add "Lets Encrypt CA" Certpath to SSVM Keystore (for cdimage.debian.org) #2541

Closed

yadvr force-pushed the test-fixes411 branch from 3938388 to 77687c6 Compare May 1, 2018 09:35

apache deleted a comment from blueorangutan May 1, 2018

borisstoyanov approved these changes May 2, 2018

View reviewed changes

yadvr self-assigned this May 2, 2018

solidfire: fix potential NPE

3aef37e

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr force-pushed the test-fixes411 branch from 3dbb2e6 to 6c42fe2 Compare May 2, 2018 10:27

apache deleted a comment from blueorangutan May 2, 2018

yadvr mentioned this pull request May 2, 2018

cloud-early-config detects unknown hypervisor type "xen-domU" #2561

Closed

yadvr force-pushed the test-fixes411 branch from 6c42fe2 to beeac58 Compare May 2, 2018 10:51

yadvr requested a review from DaanHoogland May 2, 2018 10:58

apache deleted a comment from blueorangutan May 2, 2018

yadvr force-pushed the test-fixes411 branch from beeac58 to 48fef5b Compare May 2, 2018 11:06

yadvr mentioned this pull request May 2, 2018

Upgrade to 4.11 and pre-existent saml2 authentication settings #2548

Closed

yadvr force-pushed the test-fixes411 branch from 48fef5b to e700ac0 Compare May 2, 2018 13:01

apache deleted a comment from blueorangutan May 2, 2018

yadvr requested review from GabrielBrascher, rafaelweingartner and wido May 2, 2018 13:44

ca: Fixes apache#2530 have all IPs from KVM host in issued X509 cert

318a8c8

This ensures that certificate setup includes all the IP addresses (v4 and v6) when a (KVM) host is added to CloudStack. This fixes apache#2530. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr force-pushed the test-fixes411 branch from e700ac0 to 4424abe Compare May 3, 2018 08:27

apache deleted a comment from blueorangutan May 3, 2018

yadvr added 6 commits May 3, 2018 14:01

systemvmtemplate: Fixes apache#2541 adds Letsencrypt CA cert

350cbaf

On patching, the global cacerts keystore is imported in 'cloud' service specific local keystore. This fixes apache#2541. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

vr: create tables before applying egress iptables rules

248fd91

This fixes the issue that post-upgrade egress rules are not applied on VR, restarting the network with cleanup used to be the workaround. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

test/integration: fix invalid VMware smoketests failures

576682a

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr force-pushed the test-fixes411 branch from 4424abe to 091b258 Compare May 3, 2018 08:32

apache deleted a comment from blueorangutan May 4, 2018

yadvr merged commit 05857c7 into apache:4.11 May 4, 2018

4.11.1.0: Stabilization and blocker/issues fixes #2616

4.11.1.0: Stabilization and blocker/issues fixes #2616

Uh oh!

Conversation

yadvr commented Apr 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented May 3, 2018

Uh oh!

yadvr commented May 3, 2018

Uh oh!

blueorangutan commented May 3, 2018

Uh oh!

blueorangutan commented May 3, 2018

Uh oh!

yadvr commented May 3, 2018

Uh oh!

blueorangutan commented May 3, 2018

Uh oh!

blueorangutan commented May 4, 2018

Uh oh!

blueorangutan commented May 4, 2018

Uh oh!

yadvr commented May 4, 2018

Uh oh!

yadvr commented May 4, 2018

Uh oh!

blueorangutan commented May 4, 2018

Uh oh!

yadvr commented May 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yadvr commented Apr 30, 2018 •

edited

Loading