Skip to content

Fixes: #2725#2726

Merged
fmaximus merged 1 commit intoapache:4.11from
nuagenetworks:bugfix/marvin_setup
Jul 3, 2018
Merged

Fixes: #2725#2726
fmaximus merged 1 commit intoapache:4.11from
nuagenetworks:bugfix/marvin_setup

Conversation

@fmaximus
Copy link
Contributor

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes: #2725

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@fmaximus fmaximus added this to the 4.11.2.0 milestone Jun 29, 2018
@fmaximus fmaximus requested a review from PaulAngus June 29, 2018 13:01
@borisstoyanov
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2156

@borisstoyanov
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-2832)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22384 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2726-t2832-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 1106.25 test_privategw_acl.py
test_04_nonsecured_to_secured_vm_migration Error 44.26 test_vm_life_cycle.py

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange this happened; needed change!

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on successful build and smoketests results

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks for the fix.

@fmaximus fmaximus merged commit 89c2721 into apache:4.11 Jul 3, 2018
4.11.2-SNAPSHOT * Initial Release.
4.11.2-SNAPSHOT
4.11.2-SNAPSHOT -- Rudd-O <manuel@vmops.com> Thu, 25 Mar 2010 15:12:06 -0700
cloudstack (4.11.2-SNAPSHOT) unstable; urgency=low
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be 4.11.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants