scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

[falcon78921]

Description

Minor cleanups in dhcpd_edithosts.py. Updated string formatting
to str.format(). Aligning code to Python3.

Signed-off-by: James McClune jmcclune@mcclunetechnologies.net

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

I like a good cleanup, but I doubt this is bringing us closer to python3 ;(

[falcon78921]

@DaanHoogland Yeah, I used str.format(), which is becoming a more widespread and recommended way to format strings in Python3 (replacing the % operator). I saw that os.path is also used. pathlib is becoming a better alternative for file manipulations as well (replacing os.path). If there's anything I'm missing, please let me know and I'll fix. :)

[borisstoyanov]

@blueorangutan package

[borisstoyanov]

LGTM, I'll run some smoke tests

[blueorangutan]

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2605

[borisstoyanov]

@blueorangutan test

[blueorangutan]

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3401)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31633 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3166-t3401-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 66 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestTemplateHierarchy>:setup	Error	1519.82	test_accounts.py
test_04_extract_Iso	Failure	1.08	test_iso.py
test_04_extract_template	Failure	1.09	test_templates.py
test_06_download_detached_volume	Failure	11.51	test_volumes.py

[falcon78921]

@borisstoyanov @DaanHoogland I'm just following up on this PR. If there's anything else I need to do, please let me know :)

[DaanHoogland]

@falcon78921 master is frozen till 4.12 is released. Also there are a lot of errors in travis. I see a lot of false positives so my first instinct is restarting. Please have a look if these continue to appear.

[falcon78921]

@DaanHoogland Cool :) Thanks for the update.

[yadvr]

We'll need to check but current systemvmtemplate only has python 2.7.

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[yadvr]

Confirmed, current systemvmtemplate based on Debian 9 does not have python 3 by default:
![Screenshot from 2019-05-27 18-04-42](https://user-images.githubusercontent.com/95203/58420073-
f2a15b00-80a9-11e9-9e95-54f00cf95231.png)

-1 The change may be breaking, the bigger change would be to replace all of the VR programming codebase (about 2-3k loc) with new rpc mechanism.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2791

[falcon78921]

@rhtyd Do you want me to close?

[falcon78921]

Made some corrections regarding pathlib usage