server: save GUID for KVM cluster #3396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a KVM host is added to a cluster, the cluster GUID is null. In case the KVM host fails to be added, the GUID is not set to null and if any other hosts are added an exception is thrown by the resource manager that does not allow addition of hosts to a cluster with existing hosts whose GUID is null. In case of KVM, other hosts may be added in parallel therefore this restriction can be safely removed. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
@blueorangutan package |
Member
Author
|
cc @ustcweizhou - can you review, thanks. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Member
Author
|
Tested in a local centos7.6+kvm env:
|
Member
Author
|
Moved to master here: #3398 |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a KVM host is added to a cluster, the cluster GUID is null. In case
the KVM host fails to be added, the GUID is not set to null and if any
other hosts are added an exception is thrown by the resource manager
that does not allow addition of hosts to a cluster with existing hosts
whose GUID is null.
In case of KVM, other hosts may be added in parallel therefore this
restriction can be safely removed.
Issue references:
http://mail-archives.apache.org/mod_mbox/cloudstack-users/201604.mbox/%3Cloom.20160415T120602-157@post.gmane.org%3E
http://mail-archives.apache.org/mod_mbox/cloudstack-users/201306.mbox/%3C1F7751C3-DB29-4639-9E67-9760B07C9A5B@gmail.com%3E
Types of changes