Fix 3 more findbugs performance alerts, creating boxed Long and Integer unnecessarily #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource
|
cloudstack-pull-requests #319 SUCCESS |
shwstppr
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Apr 11, 2024
* Use join instead of views for filtering volumes * Use join instead of views for filtering events * Use join instead of views for filtering accounts * Use join instead of views for filtering domains * Use join instead of views for filtering hosts * Use join instead of views for filtering storage pools * Use join instead of views for filtering service offerings * Use join instead of views for filtering disk offerings * Remove unused code * Fix unit test * Use disk_offering instead of disk_offering_view in service_offering_view * Fixup * Fix listing of diskoffering & serviceoffering * Use constants instead of strings * Make changes to prevent sql injection * Remove commented code * Prevent n+1 queries for template's response * remove unused import * refactor some code * Add missing check for service offering's join with disk offering * Fix n+1 queries for stoage pool metrics * Remove n+1 queries from list accounts * Remove unused imports * remove todo * Remove unused import * Fixup query generation for nested joins * Fixups * Fix DB exception on ClientPreparedStatement * events,alerts: Add missing indexes (apache#366) * Fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High
F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High
F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High
Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource