Fix 2 findbugs ClassCastExceptions#414
Closed
rsafonseca wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map\<String, String\> and not a Map\<String, Map\<String,String\>\> If this piece of could would get run, it would just fail trying to cast String to HashMap\<String,String\> Removed nonsense comment about casting a Collection to a Map obviously giving exception
|
cloudstack-pull-requests #390 FAILURE |
|
cloudstack-pull-requests #393 FAILURE |
kishankavala
pushed a commit
to kishankavala/cloudstack
that referenced
this pull request
Jun 25, 2015
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> This closes apache#414
yadvr
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Apr 24, 2024
Backport upstream security fixes to apple-base418
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScaleVMCmd.getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map<String, String> and not a Map<String, Map<String,String>>
UpgradeVMCmd.getDetails() is called from UserVmManagerImpl.upgradeVirtualMachine() and would fail to run, as it would try to cast String to HashMap<String,String>
Removed nonsense comment about casting a Collection to a Map obviously giving exception