-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add missing command - syncStoragePool in main branch #5312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing command - syncStoragePool in main branch #5312
Conversation
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Thanks @Pearl1594 - good catch |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 866 |
|
@blueorangutan test |
|
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1633)
|
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, has the command execution been validated as well, or just its presence?
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds a missing command - syncStoragePool, which was reverted on main (by 96c9c5a#diff-eb21dad2af4d6b0008ab4330419b8f156ac1d7176cf4ad55c246beb83296b79fL3040-R3040)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
executed the command via cmk - to validate that the API exists