-
Notifications
You must be signed in to change notification settings - Fork 1.3k
travis: fix consistent failures noticed on few tests #5399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1090 |
|
@blueorangutan test |
nvazquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Pearl1594
|
travis test passed. |
|
@blueorangutan test |
|
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1917)
|
|
Trillian test result (tid-1927)
|
Description
PR #5337 added a check to bypass username / password check for a specific hypervisor type, however, Simulator envs leverage discoverHosts ( https://github.com/apache/cloudstack/blob/main/server/src/main/java/com/cloud/resource/ResourceManagerImpl.java#L643 ) for simulating addition of a secondary store, wherein "SecondaryStorage" is passed as hypervisor type and this leads to a failure at https://github.com/apache/cloudstack/blob/main/server/src/main/java/com/cloud/resource/ResourceManagerImpl.java#L692 - i.e., the username and password check fails which in turn leads to the template properties - "size" not being set at https://github.com/apache/cloudstack/blob/main/plugins/hypervisors/simulator/src/main/java/com/cloud/resource/SimulatorSecondaryDiscoverer.java#L77. Thus, we have been noticing a few travis failures:
This PR fixes the above mentioned issue
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran the specific tests on a simulator based env and they passed