[Vmware] Fix for ovf templates with prefix

[nvazquez]

Description

This PR adds a "ovf" prefix check on Vmware template OVF files.

Fixes: #5415

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

• Export template from Vmware, verify sections contain the prefix: "ovf", examples:

    <ovf:File ovf:href="vwlc_harddisk.vmdk" ovf:id="file1" ovf:size="1380352" />
    <ovf:File ovf:href="README-OVF.txt" ovf:id="readme-ovf" ovf:size="8740" />
    <ovf:File ovf:href="C9800-CL-universalk9.17.03.03-vga.iso" ovf:id="C9800-CL-universalk9.17.03.03-vga.iso" ovf:size="1081249792" />
  </ovf:References>
  <ovf:DiskSection>
    <ovf:Info>Virtual disk information</ovf:Info>
    <ovf:Disk ovf:capacity="16" ovf:capacityAllocationUnits="byte * 2^30" ovf:diskId="vmdisk1" ovf:fileRef="file1" ovf:format="http://www.vmware.com/interfaces/specifications/vmdk.html#streamOptimized" ovf:populatedSize="293011456" />
  </ovf:DiskSection>
  <ovf:NetworkSection>
    <ovf:Info>The list of logical networks</ovf:Info>
    <ovf:Network ovf:name="GigabitEthernet1">
      <ovf:Description>Device management / service network interface. Connect it to the out of band management network.</ovf:Description>
    </ovf:Network>

• Register the template as deploy-as-is (Read settings from OVA = true)
• Register the template as normal template (Read settings from OVA = false)
• Verify both templates are registered successfully
• Verify VMs can be created from both templates

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[yadvr]

Hi @nvazquez do we know what causes the prefix to be added? Is this due to exporting ovf template from vmware, virtualbox or something else?

[blueorangutan]

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1229

[nvazquez]

@blueorangutan package

[nvazquez]

@rhtyd yes this prefix can be added when exporting a template from Vmware

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1245

[nvazquez]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1251

[nvazquez]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian Build Failed (tid-2045)

[nvazquez]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[yadvr]

Lgtm needs testing

[DaanHoogland]

Can you add to the How hs this been tested chapter in the description, @nvazquez ?

[sureshanaparti]

code LGTM

[nvazquez]

@DaanHoogland I have updated the PR description, please check. Manual tests performed by @NuxRo

[NuxRo]

LGTM, cheers @nvazquez

[nvazquez]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2076)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43389 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5448-t2076-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File