Skip to content

Comments

UI - Fixes search error in selectbox#5472

Merged
nvazquez merged 3 commits intoapache:mainfrom
utchoang:feature/fix-search-select-options
Sep 20, 2021
Merged

UI - Fixes search error in selectbox#5472
nvazquez merged 3 commits intoapache:mainfrom
utchoang:feature/fix-search-select-options

Conversation

@utchoang
Copy link

@utchoang utchoang commented Sep 20, 2021

Description

In select boxes containing resource-icon, when entering input a search, an error occurs.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

BEFORE:
image
image

AFTER:
image

How Has This Been Tested?

@Pearl1594
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5472 (SL-JID-668)

Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing, LGTM

@yadvr yadvr added this to the 4.16.0.0 milestone Sep 20, 2021
@Pearl1594
Copy link
Contributor

Pearl1594 commented Sep 20, 2021

Thanks @utchoang for identifying/fixing this issue. There are some places where this fix may need to be extended to:

  1. CreateVolume -> Zones Dropdown
  2. UploadVolume -> Zones Dropdown
  3. RegisterVolume -> Zones Dropdown
  4. ReinstallVM -> Templates Dropdown (may be required to be changed in AutogenView)
  5. CreateL2NetworkForm -> zones dropdown
  6. CreateVpc -> Zone dropdown
  7. RegisterOrUploadTemplate - zones dropdown (for both registration and upload)
  8. RegisterOrUploadIso - zones dropdown (for both)
  9. PodAdd - zones dropdown
  10. ClusterAdd - zones dropdown
  11. HostAdd - zones dropdown
  12. AddPrimaryStorage - zones
  13. AddSecondaryStorage - zones

@utchoang
Copy link
Author

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5472 (SL-JID-669)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests good

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @utchoang

@nvazquez nvazquez merged commit 121a72c into apache:main Sep 20, 2021
@utchoang utchoang deleted the feature/fix-search-select-options branch September 21, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants