xcp-ng: fix vm boot options #5543

shwstppr · 2021-10-01T06:40:58Z

Description

Use value boot option values from VM details directly similar to other hypervisor plugins instead of relying on boot properties explicitly set for VirtualMachineTO.

Fixes #5535

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Use value boot option values from VM details directly similar to other hypervisor plugins instead of relying on boot properties explicitly set for VirtualMachineTO. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-10-01T06:45:14Z

@blueorangutan package

blueorangutan · 2021-10-01T06:46:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-10-01T07:22:00Z

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian. SL-JID 1468

shwstppr · 2021-10-01T07:25:13Z

@blueorangutan package

blueorangutan · 2021-10-01T07:27:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-10-01T08:04:34Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 1471

yadvr · 2021-10-02T09:41:46Z

@blueorangutan test centos7 xenserver-71

blueorangutan · 2021-10-02T09:42:02Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

yadvr · 2021-10-02T09:43:27Z

@blueorangutan test centos7 xcpng-82

blueorangutan · 2021-10-02T09:44:02Z

@rhtyd unsupported parameters provided. Supported mgmt server os are: centos7, centos6, alma8, ubuntu18, suse15, ubuntu20, rocky8, centos8. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-centos8, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

blueorangutan · 2021-10-02T20:00:04Z

Trillian test result (tid-2295)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35943 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5543-t2295-xenserver-71.zip
Smoke tests completed. 86 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	95.98	test_kubernetes_clusters.py

yadvr · 2021-10-03T09:24:02Z

@blueorangutan test centos7 xcpng82

blueorangutan · 2021-10-03T09:25:03Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

blueorangutan · 2021-10-03T23:30:05Z

Trillian test result (tid-2303)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49504 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5543-t2303-xcpng82.zip
Smoke tests completed. 86 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Failure`	4.77	test_scale_vm.py

...sors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java

sureshanaparti · 2021-10-05T05:36:35Z

@blueorangutan package

blueorangutan · 2021-10-05T05:37:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-10-05T06:16:14Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 1501

sureshanaparti · 2021-10-05T07:24:25Z

@blueorangutan package

blueorangutan · 2021-10-05T07:25:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-10-06T11:34:21Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1519

AlexanderKgr · 2021-10-06T11:48:01Z

@AlexanderKgr

as I pointed out the templates I've used for testing were registered in 4.15.2, is that what you imply by 'from previous versions'?

no, this is not yet merged, you can build the branch yourself and test it out. Do not wait until it gets merged since we're closing on the code freeze and we might cut the RC soon, probably by end of the week.

From 4.15.1
Can you help with build and test? Have never done this before

borisstoyanov · 2021-10-06T11:56:47Z

@AlexanderKgr if you're not a developer maybe it'll be hard to build it yourself, I have packages is there a location I can upload them fro you?

AlexanderKgr · 2021-10-06T12:09:54Z

@AlexanderKgr if you're not a developer maybe it'll be hard to build it yourself, I have packages is there a location I can upload them fro you?

I am network admin at a company and have home lab.both with cloudstack.
Upload them somewhere like gdrive one drive etc and send me the link. For debian version

borisstoyanov · 2021-10-06T12:28:17Z

@AlexanderKgr I've uploaded management and common deb packages here: https://drive.google.com/drive/folders/1SLdFLWVm6gQKEedMVI7nX-16w_ZSBkle?usp=sharing

you'll have to manually deal with dependencies packages and if you're running 4.15 you'll need to register systemvm template to upgrade properly.

AlexanderKgr · 2021-10-06T12:34:40Z

@AlexanderKgr I've uploaded management and common deb packages here: https://drive.google.com/drive/folders/1SLdFLWVm6gQKEedMVI7nX-16w_ZSBkle?usp=sharing

you'll have to manually deal with dependencies packages and if you're running 4.15 you'll need to register systemvm template to upgrade properly.

Thanks. I am at 4.15.2. will install it in around 3 hours

nvazquez · 2021-10-06T12:44:44Z

Thanks @borisstoyanov
@AlexanderKgr please let us know after you finish your tests, thanks

borisstoyanov · 2021-10-06T13:05:25Z

@AlexanderKgr @nvazquez I think this should be fine, I've created the templates with 4.15.1 and with 4.15.2 I encountered this blocker, then upgraded to this branch and was able to start my VMs once again.

nvazquez · 2021-10-06T13:27:25Z

@blueorangutan test centos7 xcpng82

blueorangutan · 2021-10-06T13:28:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

AlexanderKgr · 2021-10-06T15:17:12Z

@AlexanderKgr I've uploaded management and common deb packages here: https://drive.google.com/drive/folders/1SLdFLWVm6gQKEedMVI7nX-16w_ZSBkle?usp=sharing

you'll have to manually deal with dependencies packages and if you're running 4.15 you'll need to register systemvm template to upgrade properly.

gdrive has sent you a msg to allow me to view files

AlexanderKgr · 2021-10-06T19:19:29Z

with the version @borisstoyanov gave me

have issues updating from 4.15.3
db connection issue

reverting to previous db and 4.15.3 fixes this issue.
tried to install 2 times
there was a new option to select

the 1st time i selected N and the 2nd i selected Y
The same error

blueorangutan · 2021-10-07T02:46:30Z

Trillian test result (tid-2328)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46530 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5543-t2328-xcpng82.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

borisstoyanov · 2021-10-07T04:27:21Z

@AlexanderKgr I did not had these issues, I highly suspect something went wrong with updating, but could be wrong since I was on centos8 instead of debian, can I ask you to test this once more next week when we have RC1 probably (keep an eye on the mailing lists), since you'll be able to properly update this with dependencie packages manager?

AlexanderKgr · 2021-10-07T04:54:30Z

@AlexanderKgr I did not had these issues, I highly suspect something went wrong with updating, but could be wrong since I was on centos8 instead of debian, can I ask you to test this once more next week when we have RC1 probably (keep an eye on the mailing lists), since you'll be able to properly update this with dependencie packages manager?

Sure. No problem neighbor. I am waiting for rc1 to test. Thanks

sureshanaparti · 2021-10-07T07:13:01Z

I was not able to reproduce this with vms deployed in 4.15.2 with UEFI (secured), then upgraded to this branch. I was able to successfully stop and start VMs with no issues.

There was one warning on stopping VM, it probably does not have to do with this change?

2021-10-06 11:16:03,345 DEBUG [c.c.h.x.r.w.x.CitrixStopCommandWrapper] (DirectAgent-76:ctx-7c82b552) (logid:de9224d6) 9. The VM i-2-8-VM is in Stopping state
2021-10-06 11:16:03,362 WARN  [c.c.h.x.r.CitrixResourceBase] (DirectAgent-76:ctx-7c82b552) (logid:de9224d6) Task failed! Task record:                 uuid: 998fc3ab-99cb-64a6-2550-efc27c14f830
           nameLabel: Async.VM.clean_shutdown
     nameDescription:
   allowedOperations: []
   currentOperations: {}
             created: Wed Oct 06 11:16:03 UTC 2021
            finished: Wed Oct 06 11:16:03 UTC 2021
              status: failure
          residentOn: com.xensource.xenapi.Host@d4f0371d
            progress: 1.0
                type: <none/>
              result:
           errorInfo: [VM_LACKS_FEATURE, OpaqueRef:790a1a78-38cd-4590-aca5-d981d5561cc4]
         otherConfig: {}
           subtaskOf: com.xensource.xenapi.Task@aaf13f6f
            subtasks: []

2021-10-06 11:16:03,367 DEBUG [c.c.h.x.r.CitrixResourceBase] (DirectAgent-76:ctx-7c82b552) (logid:de9224d6) Unable to shutdown VM(i-2-8-VM) with force=false on host(ac3de140-597d-4435-ad55-62044d7d2637) due to Task failed! Task record:                 uuid: 998fc3ab-99cb-64a6-2550-efc27c14f830
           nameLabel: Async.VM.clean_shutdown
     nameDescription:
   allowedOperations: []
   currentOperations: {}
             created: Wed Oct 06 11:16:03 UTC 2021
            finished: Wed Oct 06 11:16:03 UTC 2021
              status: failure
          residentOn: com.xensource.xenapi.Host@d4f0371d
            progress: 1.0
                type: <none/>
              result:
           errorInfo: [VM_LACKS_FEATURE, OpaqueRef:790a1a78-38cd-4590-aca5-d981d5561cc4]
         otherConfig: {}
           subtaskOf: com.xensource.xenapi.Task@aaf13f6f
            subtasks: []

2021-10-06 11:16:04,632 DEBUG [c.c.a.ApiServlet] (qtp249034932-13:ctx-f9d3d0fb) (logid:0a34122b) ===START===  172.16.250.11 -- GET  jobId=de9224d6-1812-41bc-82c4-31089104446f&command=queryAsyncJobResult&response=json

@harikrishna-patnala Have you noticed any warning while stopping VM in your tests?

harikrishna-patnala · 2021-10-07T07:49:11Z

@sureshanaparti I've observed the same warning both before and after fix and for all types of boot options, probably this is related to the specific version of XCP, nothing related to these changes

sureshanaparti · 2021-10-07T07:51:10Z

@sureshanaparti I've observed the same warning both before and after fix and for all types of boot options, probably this is related to the specific version of XCP, nothing related to these changes

Thanks for the confirmation @harikrishna-patnala

sureshanaparti · 2021-10-07T07:51:59Z

Merging based on LGTMs and test results.

sureshanaparti · 2021-10-07T07:57:33Z

Hi @AlexanderKgr, Please test with RC1 packages (watch out for the announcement in the mailing list), and share the results here. Thanks.

yadvr · 2021-10-11T07:48:03Z

@AlexanderKgr since the PR was merged, you can actually test ahead of RC1 using the latest/nightly builds from http://download.cloudstack.org/testing/nightly/latest/

AlexanderKgr · 2021-10-11T20:00:31Z

@AlexanderKgr since the PR was merged, you can actually test ahead of RC1 using the latest/nightly builds from http://download.cloudstack.org/testing/nightly/latest/

tried to test with cloudstack-management_4.16.0.0-snapshot.20211011_xenial_all.deb but
there was this option

i selected N and it broke my installation. had to revert.
Is this option correct?

yadvr · 2021-10-12T04:47:37Z

@AlexanderKgr hope this still was in a dev-test env, selecting N to not overwrite the db properties file was right. What error did you get in logs from updating the packages? (maybe you hit an upgrade issue we can try to fix)

Can you try again and report us your issues
http://download.cloudstack.org/testing/nightly/latest/debian/4.16/

AlexanderKgr · 2021-10-12T05:04:03Z

@AlexanderKgr hope this still was in a dev-test env, selecting N to not overwrite the db properties file was right. What error did you get in logs from updating the packages? (maybe you hit an upgrade issue we can try to fix)

Can you try again and report us your issues http://download.cloudstack.org/testing/nightly/latest/debian/4.16/

yes it was a dev-test env.
No errors in update but there was an issue in starting the service cloudstack-management. Will try again in the evening.

AlexanderKgr · 2021-10-14T19:18:00Z

@AlexanderKgr hope this still was in a dev-test env, selecting N to not overwrite the db properties file was right. What error did you get in logs from updating the packages? (maybe you hit an upgrade issue we can try to fix)

Can you try again and report us your issues http://download.cloudstack.org/testing/nightly/latest/debian/4.16/

Tried it with CloudStack 4.16.0.0-snapshot.20211014 and i can confirm that it is working.
Created new vms from templates, stopped them start them. Everything works.
Thank you all! @shwstppr @rhtyd @sureshanaparti @borisstoyanov @nvazquez @harikrishna-patnala

nvazquez · 2021-10-14T21:43:01Z

Excellent thanks @AlexanderKgr !

xcp-ng: fix vm boot options

d436b34

Use value boot option values from VM details directly similar to other hypervisor plugins instead of relying on boot properties explicitly set for VirtualMachineTO. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr added this to the 4.16.0.0 milestone Oct 3, 2021

yadvr approved these changes Oct 3, 2021

View reviewed changes

yadvr requested review from nvazquez and sureshanaparti October 3, 2021 09:32

yadvr added the status:needs-testing label Oct 3, 2021

sureshanaparti reviewed Oct 4, 2021

View reviewed changes

...sors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java Outdated Show resolved Hide resolved

vladimirpetrov self-assigned this Oct 4, 2021

nvazquez mentioned this pull request Oct 4, 2021

After installing 4.15.2.0 instances created from template with uefi cannot boot for second time (xcp-ng 8.2) #5535

Closed

sureshanaparti changed the base branch from 4.15 to main October 5, 2021 05:36

yadvr requested a review from harikrishna-patnala October 5, 2021 05:55

sureshanaparti merged commit 2a42a01 into apache:main Oct 7, 2021

nvazquez added component:XenServer type:bug and removed status:needs-testing labels Oct 14, 2021

xcp-ng: fix vm boot options #5543

xcp-ng: fix vm boot options #5543

Uh oh!

Conversation

shwstppr commented Oct 1, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

shwstppr commented Oct 1, 2021

Uh oh!

blueorangutan commented Oct 1, 2021

Uh oh!

blueorangutan commented Oct 1, 2021

Uh oh!

shwstppr commented Oct 1, 2021

Uh oh!

blueorangutan commented Oct 1, 2021

Uh oh!

blueorangutan commented Oct 1, 2021

Uh oh!

yadvr commented Oct 2, 2021

Uh oh!

blueorangutan commented Oct 2, 2021

Uh oh!

yadvr commented Oct 2, 2021

Uh oh!

blueorangutan commented Oct 2, 2021

Uh oh!

blueorangutan commented Oct 2, 2021

Uh oh!

yadvr commented Oct 3, 2021

Uh oh!

blueorangutan commented Oct 3, 2021

Uh oh!

blueorangutan commented Oct 3, 2021

Uh oh!

Uh oh!

sureshanaparti commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 5, 2021

Uh oh!

sureshanaparti commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 6, 2021

Uh oh!

AlexanderKgr commented Oct 6, 2021

Uh oh!

borisstoyanov commented Oct 6, 2021

Uh oh!

AlexanderKgr commented Oct 6, 2021

Uh oh!

borisstoyanov commented Oct 6, 2021

Uh oh!

AlexanderKgr commented Oct 6, 2021

Uh oh!

nvazquez commented Oct 6, 2021

Uh oh!

borisstoyanov commented Oct 6, 2021

Uh oh!

nvazquez commented Oct 6, 2021

Uh oh!

blueorangutan commented Oct 6, 2021

Uh oh!

AlexanderKgr commented Oct 6, 2021

Uh oh!

AlexanderKgr commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Oct 7, 2021

Uh oh!

borisstoyanov commented Oct 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

AlexanderKgr commented Oct 6, 2021 •

edited

Loading

borisstoyanov commented Oct 7, 2021 •

edited

Loading

yadvr commented Oct 12, 2021 •

edited

Loading