Skip to content

ui: Prevent multiple VM selection and list only VMs IP #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weizhouapache merged 1 commit into from
Oct 22, 2021
Merged

ui: Prevent multiple VM selection and list only VMs IP #5609

weizhouapache merged 1 commit into from
Oct 22, 2021

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Oct 22, 2021

Description

This PR fixes #5605

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
Copy link

utchoang commented Oct 22, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Oct 22, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 22, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5609 (SL-JID-777)

utchoang
utchoang approved these changes Oct 22, 2021
View reviewed changes
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadvr yadvr added this to the 4.16.0.0 milestone Oct 22, 2021
@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Oct 22, 2021

ping @sureshanaparti - can you please review & test. Thanks.

weizhouapache
weizhouapache approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok

sureshanaparti
sureshanaparti approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm

@weizhouapache weizhouapache merged commit de6293b into apache:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@utchoang utchoang utchoang approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:UI type:bug

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

Port forwarding rule creation from UI, allows multiple VM selection and lists all selected VM IPs.

7 participants

@Pearl1594 @utchoang @blueorangutan @yadvr @sureshanaparti @weizhouapache @nvazquez