[VMware] Fix service offerings listing on appliances deployment options

[nvazquez]

Description

The service offerings matching the deployment options requirements were not listed, except unconstrained offerings. This PR fixes the listing of service offerings on VMware deployment options:

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1847

[shwstppr]

@nvazquez can you please elaborate what behaviour this PR fixes

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 1850

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1852

[nvazquez]

@blueorangutan test centos7 vmware-67u3

[sureshanaparti]

code LGTM

[sureshanaparti]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2637)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34127 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5752-t2637-vmware-67u3.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

so,

Suggested change

	((item.iscustomized === false && maxMemory < this.minimumMemory) ||
	(item.iscustomized === true && maxMemory < this.minimumMemory))) {
	(maxMemory < this.minimumMemory) // && (item.iscustomized === false || item.iscustomised == true)

?

[sureshanaparti]

so,

?

+1, maxMemory < this.minimumMemory should be fine. @nvazquez can you check and update.