Make template flags isPublic, isFeatured, isExtractable editable in ui

[DK101010]

Description

This PR add template flags isPublic, isFeatured, isExtractable to ui

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

own vmware env

[DaanHoogland]

@DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?

[DK101010]

@DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?

Only as admin and to be honest, I have no clue what do you mean. :D

[DaanHoogland]

@DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?

Only as admin and to be honest, I have no clue what do you mean. :D

ok, not sure if a user is allowed the same on template flags as the admin, hence my question. testing will have to prove the pudding

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 1914

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 1918

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1920

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DK101010]

@DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?

Only as admin and to be honest, I have no clue what do you mean. :D

ok, not sure if a user is allowed the same on template flags as the admin, hence my question. testing will have to prove the pudding

Hmm ... good question. Have no Idea. These flags already existed in the old ui. How was it there?

[blueorangutan]

Trillian test result (tid-2674)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33305 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5771-t2674-kvm-centos7.zip
Smoke tests completed. 86 look OK, 5 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	Error	0.62	test_primary_storage.py
test_01_primary_storage_nfs	Error	0.12	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	Error	0.22	test_primary_storage.py
test_01_secure_vm_migration	Error	170.26	test_vm_life_cycle.py
test_02_unsecure_vm_migration	Error	274.57	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	147.32	test_vm_life_cycle.py
test_08_migrate_vm	Error	46.94	test_vm_life_cycle.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	32.99	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	63.78	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	44.27	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	86.54	test_kubernetes_clusters.py
test_02_list_snapshots_with_removed_data_store	Error	9.50	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	9.50	test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance	Error	305.20	test_hostha_kvm.py

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1965

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2696)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31560 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5771-t2696-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[davidjumani]

There exist APIs updateIsoPermissions and updateTemplatePermissions which do pretty much the exact same thing
It is also available in the UI

[DK101010]

There exist APIs updateIsoPermissions and updateTemplatePermissions which do pretty much the exact same thing It is also available in the UI

Oh ok, that is new for me. Thanks for the hint. I'll close the PR.