Skip to content

UI: show SSH keys step in VM deployment only if user can 'listSSHKeyPairs'#5804

Merged
sureshanaparti merged 1 commit intoapache:4.16from
CLDIN:ui-show-sshkeys-if-user-is-allowed
Dec 27, 2021
Merged

UI: show SSH keys step in VM deployment only if user can 'listSSHKeyPairs'#5804
sureshanaparti merged 1 commit intoapache:4.16from
CLDIN:ui-show-sshkeys-if-user-is-allowed

Conversation

@GabrielBrascher
Copy link
Copy Markdown
Member

@GabrielBrascher GabrielBrascher commented Dec 23, 2021

Description

This PR Fixes issue #5765 UI: SSH key option should not be presented if not allowed/support.
After applying this patch, the VM deployment via UI shows the SSH Keys step only if the user/account has access to the listSSHKeyPairs command.

Fixes: #5765

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

1.User that can list SSH Keys:

image

2.User that is not allowed to list SSH Keys:

image

How Has This Been Tested?

  1. Deploy VM via user that has access to listSSHKeyPairs
  2. UI shows all keys the user can access
  3. create role type that don't allow listSSHKeyPairs
  4. Deploy VM via user that is not allowed to call API command listSSHKeyPairs
  5. UI does not present the SSH keys step to the user

@GabrielBrascher GabrielBrascher added this to the 4.16.1.0 milestone Dec 23, 2021
@GabrielBrascher GabrielBrascher self-assigned this Dec 23, 2021
@GabrielBrascher GabrielBrascher changed the title Change UI VM deployment to show SSH keys only if user has keys UI: show SSH keys step in VM deployment only if user can 'listSSHKeyPairs' Dec 23, 2021
@GabrielBrascher
Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@GabrielBrascher a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5804 (SL-JID-930)

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@GutoVeronezi GutoVeronezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti sureshanaparti merged commit 19325d0 into apache:4.16 Dec 27, 2021
GabrielBrascher added a commit to CLDIN/cloudstack that referenced this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

UI: SSH key option should not be presented if not allowed/support

6 participants