-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI - Fixes Pod, Cluster selected is incorrect on addHost dialog #5869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI - Fixes Pod, Cluster selected is incorrect on addHost dialog #5869
Conversation
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✖️ |
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Hi @utchoang when changing the zone, the pod name shown/selected in the list box doesn't change, but the list items of the 'Pod name' are updated with new pod names. Also, when changing the pod, the cluster name shown and list items of the 'Cluster Name' doesn't change. Please check. |
|
@sureshanaparti I have checked and it is working properly, can you check again? |
|
Check this @utchoang PR5869_test.mov |
|
@utchoang I think you fixed a bug, for sure. Just not the one I reported. As @sureshanaparti describes, the options of clusters should also change when a different Pod is chosen. My guess is that something similar probably happens when a cluster is chosen (for hosts). |
|
@sureshanaparti @DaanHoogland I've fixed. Please test again. Thanks. |
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@utchoang clusters name list is not updated properly when there are no clusters in the pod. please check. PR5869_test_2.mov |
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Hi @utchoang Can you check with 'DummySGBasic' zone (in http://qa.cloudstack.cloud/), which doesn't have pods and clusters. I still notice cluster names are loaded in the list view, instead empty. |
|
@sureshanaparti Sorry for the complexity, please check it again. Thanks. |
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Verified. LGTM. |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM


Description
This PR fixes #5864
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?