Skip to content

Conversation

@utchoang
Copy link

Description

This PR fixes #5864

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
Copy link
Author

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✖️
(SL-JID-1020)

@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Jan 17, 2022
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@apache apache deleted a comment from blueorangutan Jan 17, 2022
@apache apache deleted a comment from blueorangutan Jan 17, 2022
@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5869 (SL-JID-1025)

@sureshanaparti
Copy link
Contributor

Hi @utchoang when changing the zone, the pod name shown/selected in the list box doesn't change, but the list items of the 'Pod name' are updated with new pod names. Also, when changing the pod, the cluster name shown and list items of the 'Cluster Name' doesn't change. Please check.

@sureshanaparti sureshanaparti self-requested a review January 17, 2022 07:47
@utchoang
Copy link
Author

utchoang commented Jan 17, 2022

@sureshanaparti I have checked and it is working properly, can you check again?
bandicam-2022-01-17-14-55-27-502

@sureshanaparti
Copy link
Contributor

Check this @utchoang

PR5869_test.mov

@DaanHoogland
Copy link
Contributor

@utchoang I think you fixed a bug, for sure. Just not the one I reported. As @sureshanaparti describes, the options of clusters should also change when a different Pod is chosen. My guess is that something similar probably happens when a cluster is chosen (for hosts).

@utchoang
Copy link
Author

@sureshanaparti @DaanHoogland I've fixed. Please test again. Thanks.

@apache apache deleted a comment from blueorangutan Jan 17, 2022
@apache apache deleted a comment from blueorangutan Jan 17, 2022
@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5869 (SL-JID-1031)

@sureshanaparti
Copy link
Contributor

@utchoang clusters name list is not updated properly when there are no clusters in the pod. please check.

PR5869_test_2.mov

@apache apache deleted a comment from blueorangutan Jan 18, 2022
@apache apache deleted a comment from blueorangutan Jan 18, 2022
@utchoang
Copy link
Author

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5869 (SL-JID-1033)

@sureshanaparti
Copy link
Contributor

Hi @utchoang Can you check with 'DummySGBasic' zone (in http://qa.cloudstack.cloud/), which doesn't have pods and clusters. I still notice cluster names are loaded in the list view, instead empty.

PR5869_test_18jan2022

@utchoang
Copy link
Author

@sureshanaparti Sorry for the complexity, please check it again. Thanks.

@apache apache deleted a comment from blueorangutan Jan 18, 2022
@apache apache deleted a comment from blueorangutan Jan 18, 2022
@utchoang
Copy link
Author

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5869 (SL-JID-1037)

@sureshanaparti
Copy link
Contributor

Verified. LGTM.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

only the first POD is queried for clusters during addHost dialog

4 participants