Skip to content

Removed redundant parsing of VMSnapshot usage record. #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DaanHoogland merged 1 commit into from
Jan 24, 2022
Merged

Removed redundant parsing of VMSnapshot usage record. #5872

DaanHoogland merged 1 commit into from
Jan 24, 2022

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Jan 18, 2022

Description

This PR removes the redundant parsing of VMSnapshot usage record.

Fixes #5662

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@sureshanaparti sureshanaparti linked an issue Jan 18, 2022 that may be closed by this pull request
Usage: Duplicated VMSnapshot usage record #5662
Closed
@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Jan 18, 2022
sureshanaparti
sureshanaparti commented Jan 18, 2022
View reviewed changes
usage/src/main/java/com/cloud/usage/UsageManagerImpl.java
if (!parsed) {
s_logger.debug("VM Snapshot usage successfully parsed? " + parsed + " (for account: " + account.getAccountName() + ", id: " + account.getId() + ")");
}
}
Copy link
Contributor Author

@sureshanaparti sureshanaparti Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same parsing is performed at line# 955 - 960.

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Jan 18, 2022

@blueorangutan package

@sureshanaparti sureshanaparti self-assigned this Jan 18, 2022
DaanHoogland
DaanHoogland approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm (no real functional changes)

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Jan 18, 2022

@blueorangutan package

1 similar comment
@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Jan 19, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 19, 2022

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 19, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2250

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 19, 2022

@blueorangutan test keepEnv

@blueorangutan
Copy link

blueorangutan commented Jan 19, 2022

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jan 22, 2022

Trillian test result (tid-2935)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31347 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5872-t2935-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland self-assigned this Jan 24, 2022
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 24, 2022

tested in a lab, works as expected.

borisstoyanov
borisstoyanov approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code review

@DaanHoogland DaanHoogland merged commit 06b5e84 into apache:4.16 Jan 24, 2022
@sureshanaparti sureshanaparti mentioned this pull request Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@nvazquez nvazquez Awaiting requested review from nvazquez

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:usage-server

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.

Usage: Duplicated VMSnapshot usage record

4 participants

@sureshanaparti @blueorangutan @DaanHoogland @borisstoyanov