-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI - Fixes UI bugs #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI - Fixes UI bugs #6162
Conversation
|
Thanks for the PR @utchoang - 2 new issues have been added (about backup offerings) since you have open the PR, if its not too much to ask can you please consider them as well on this PR? |
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Thanks @utchoang I have validated the following:
Have found some additional issues while testing the PR:
|
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@nvazquez |
|
@utchoang When the user clicks on a specific ssh key, it should go into the detail view of that key. However it results in a 404. Caused by using |
|
Yes @utchoang as @davidjumani describes, the issue comes when clicking on any created SSH key on the list |
|
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Thanks for the fixes @utchoang, verified the reported ones are fixed. Strangely the SSH keys now works when clicking on them from SSH keys list but if I create a comment for it and try to navigate to a SSH key from the comments section then I still get the 404 error |
|
@nvazquez I fixed it, Please check again. thanks |
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
nvazquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @utchoang - LGTM, manually tested OK
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manually tested ok
* fixes * remove console * fix hidden clear notification button * fixes * fixes * fixes navigation to ssh from comments



Description
This PR fixes #6107
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?