Skip to content

Conversation

@utchoang
Copy link

Description

This PR fixes #6107

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@nvazquez
Copy link
Contributor

nvazquez commented Mar 24, 2022

Thanks for the PR @utchoang - 2 new issues have been added (about backup offerings) since you have open the PR, if its not too much to ask can you please consider them as well on this PR?

@nvazquez
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6162 (SL-JID-1298)

@nvazquez
Copy link
Contributor

nvazquez commented Mar 25, 2022

Thanks @utchoang I have validated the following:

  • As user: Does not refresh dashboard values when switching from a project to the default view -> FIXED
  • Launch VM and stay on page does not work -> FIXED
  • Destroy instance expanded menu throws errors in the console -> FIXED
  • Clear notification button remains when a notification is dismissed via the 'x' icon -> FIXED

Have found some additional issues while testing the PR:

  • As a user, accepting a project invitation worked but after accepting it the page continued loading and the popup didn't close - had to refresh the page to continue

Screen Shot 2022-03-25 at 11 12 13

  • As a user, the events view below the dashboard is not aligned (it works when switching to a project)

Screen Shot 2022-03-25 at 11 15 12

  • On a project view, the Kubernetes and Kubernetes ISO icons are not visible:

Screen Shot 2022-03-25 at 11 28 05

  • Clicking on a SSH key gives 404 error

@utchoang
Copy link
Author

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6162 (SL-JID-1305)

@utchoang
Copy link
Author

@nvazquez Clicking on a SSH key gives 404 error does it have to click SSH key pair from the menu? I tried to do it, no problem at all?

@davidjumani
Copy link
Contributor

davidjumani commented Mar 28, 2022

@utchoang When the user clicks on a specific ssh key, it should go into the detail view of that key. However it results in a 404. Caused by using name=<key-id> instead of name=<key-name> in the request when the record has annotations
https://github.com/apache/cloudstack/blob/main/ui/src/components/view/ListView.vue#L102
should have the same check for ssh as
https://github.com/apache/cloudstack/blob/main/ui/src/components/view/ListView.vue#L113

@nvazquez
Copy link
Contributor

Yes @utchoang as @davidjumani describes, the issue comes when clicking on any created SSH key on the list

@davidjumani
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6162 (SL-JID-1311)

@nvazquez
Copy link
Contributor

nvazquez commented Mar 29, 2022

Thanks for the fixes @utchoang, verified the reported ones are fixed. Strangely the SSH keys now works when clicking on them from SSH keys list but if I create a comment for it and try to navigate to a SSH key from the comments section then I still get the 404 error

@utchoang
Copy link
Author

@nvazquez I fixed it, Please check again. thanks

@utchoang
Copy link
Author

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6162 (SL-JID-1314)

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @utchoang - LGTM, manually tested OK

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually tested ok

@nvazquez nvazquez merged commit 1a304cc into apache:main Mar 30, 2022
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Mar 31, 2022
* fixes

* remove console

* fix hidden clear notification button

* fixes

* fixes

* fixes navigation to ssh from comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

UI Bug Tracker

6 participants