api: Fix reset configuration

[Pearl1594]

Description

This PR fixes issue with resetConfiguration for settings defined in Config.java

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before Fix:

Post Fix:
Successfully able to reset config

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2996

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

quite frankly, I think this is due to technical debt and we should not fix this but phase those configs defined in Config.java out.

[weizhouapache]

quite frankly, I think this is due to technical debt and we should not fix this but phase those configs defined in Config.java out.

@DaanHoogland
reset configuration is already supported in 4.16.1 (see #4230). this is a bug fix .

[weizhouapache]

tested ok.

[DaanHoogland]

quite frankly, I think this is due to technical debt and we should not fix this but phase those configs defined in Config.java out.

@DaanHoogland reset configuration is already supported in 4.16.1 (see #4230). this is a bug fix .

It is supported for modern ConfigKey entries, this is extra. I think any Config that needs resetting should be modernised.

[Pearl1594]

You're right @DaanHoogland . And that's something that could be targeted in the next release. This PR pretty much aligns to the way updateConfiguration works.

[weizhouapache]

quite frankly, I think this is due to technical debt and we should not fix this but phase those configs defined in Config.java out.

@DaanHoogland reset configuration is already supported in 4.16.1 (see #4230). this is a bug fix .

It is supported for modern ConfigKey entries, this is extra. I think any Config that needs resetting should be modernised.

@DaanHoogland
in my opinion, from cloudstack user's view, they should be same: all can be set, updated and reset, no matter they are defined by ConfigKey or in Config.java.
It would be good to move configurations defined in Config.java to ConfigKey, but it is not prerequisite for reset configuration.

[nvazquez]

Code LGTM

[blueorangutan]

Trillian test result (tid-3733)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35761 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6168-t3733-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_disable_oobm_ha_state_ineligible	Error	1511.84	test_hostha_kvm.py

[weizhouapache]

the test failure is not related to this PR.
merging