You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a recent commit the way host CPU speed is detected was changed to use lscpu. This is a great enhancement, but it changed the detected speed from being the host's max turbo frequency to being the base clock. I agree this is the ideal speed to use since the max turbo frequency usually is not achieved by all cores at once. To ensure the fallback of using cpufreq files matches this behavior, we change the fallback to look at the base_frequency file rather than cpuinfo_max_freq.
Introduce agent.properties setting host.cpu.manual.speed.mhz to allow the admin to set the frequency in case all else fails.
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
In a recent commit the way host CPU speed is detected was changed to use
lscpu. This is a great enhancement, but it changed the detected speed from being the host's max turbo frequency to being the base clock. I agree this is the ideal speed to use since the max turbo frequency usually is not achieved by all cores at once. To ensure the fallback of usingcpufreqfiles matches this behavior, we change the fallback to look at thebase_frequencyfile rather thancpuinfo_max_freq.Introduce agent.properties setting
host.cpu.manual.speed.mhzto allow the admin to set the frequency in case all else fails.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?