Skip to content

UI: Fix custom unconstrained for a zone does not show CPU speed#6285

Merged
nvazquez merged 1 commit into
apache:4.16from
shapeblue:fixcustomunconstrcpuspeed
Apr 19, 2022
Merged

UI: Fix custom unconstrained for a zone does not show CPU speed#6285
nvazquez merged 1 commit into
apache:4.16from
shapeblue:fixcustomunconstrcpuspeed

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez commented Apr 19, 2022

Description

This PR fixes an issue in UI in which CPU speed is not displayed for custom unconstrained offerings for a specific zone (specified on the offering creation)

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Create custom unconstrained offering selecting a zone
  • Deploy VM selecting offering -> CPU speed is visible after the fix

@nvazquez nvazquez added this to the 4.17.0.0 milestone Apr 19, 2022
@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Apr 19, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 19, 2022

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

slavkap
slavkap approved these changes Apr 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@slavkap slavkap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
manually tested

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 19, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6285 (SL-JID-1403)

weizhouapache
weizhouapache approved these changes Apr 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@nvazquez nvazquez merged commit 365966d into apache:4.16 Apr 19, 2022
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@nvazquez @yadvr
UI: Fix custom unconstrained for a zone does not show CPU speed (apac…
2c2fc6e 
…he#6285)

(cherry picked from commit 365966d)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@nvazquez @yadvr
UI: Fix custom unconstrained for a zone does not show CPU speed (apac…
6d1caa3 
…he#6285)

(cherry picked from commit 365966d)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@slavkap slavkap slavkap approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@utchoang utchoang Awaiting requested review from utchoang

Assignees

No one assigned

Labels

component:UI type:bug

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nvazquez @blueorangutan @Pearl1594 @slavkap @weizhouapache