Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Apr 26, 2022

Description

For user and project dashborad event resource details were not showing as shown in admin dashboard.
API, UI shows name of the resource as event resourcename. Changed it to displaytext of the resource for consistency.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before:
Screenshot from 2022-04-26 12-41-39
Screenshot from 2022-04-26 12-43-27

After:
Screenshot from 2022-04-26 12-41-54
Screenshot from 2022-04-26 13-18-14

How Has This Been Tested?

For user and project dashborad event resource details were not showing as shown in admin dashboard.
API, UI shows name of the resource as event resourcename. Changed it to displaytext of the resource for consistency

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6315 (SL-JID-1473)

@shwstppr shwstppr marked this pull request as ready for review April 26, 2022 07:49
@acs-robot
Copy link

PR Coverage Report

CLASS INSTRUCTION MISSED INSTRUCTION COVERED BRANCH MISSED BRANCH COVERED LINE MISSED LINE COVERED
EventJoinDaoImpl 333 0 18 0 58 0

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3308

Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI Code LGTM!

@shwstppr
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez nvazquez added this to the 4.17.0.0 milestone Apr 26, 2022
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

Trillian test result (tid-4039)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42456 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6315-t4039-kvm-centos7.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_verify_ipv6_network Failure 349.23 test_network_ipv6.py
test_02_verify_ipv6_network_redundant Failure 136.18 test_network_ipv6.py

@nvazquez nvazquez merged commit f8920b9 into apache:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants