Updated PowerFlex/ScaleIO storage plugin to support separate (storage) network for Hosts(KVM)/Storage connection. #6367

sureshanaparti · 2022-05-09T09:55:24Z

Description

This PR enhances the existing PowerFlex/ScaleIO storage plugin to support separate (storage) network for Hosts(KVM)/Storage connection, mainly the SDC (ScaleIo Data Client) connection.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested VM/Volume operations on PowerFlex/ScaleIO storage.

sureshanaparti · 2022-05-09T10:12:47Z

@blueorangutan package

blueorangutan · 2022-05-09T10:13:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti · 2022-05-09T11:09:22Z

@blueorangutan package

blueorangutan · 2022-05-09T11:10:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-05-09T11:49:29Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3374

sureshanaparti · 2022-05-09T11:54:42Z

@blueorangutan test

blueorangutan · 2022-05-09T11:55:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-05-09T22:41:16Z

Trillian test result (tid-4152)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37395 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6367-t4152-kvm-centos7.zip
Smoke tests completed. 96 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

sureshanaparti · 2022-05-10T10:57:53Z

@blueorangutan package

blueorangutan · 2022-05-10T10:59:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-05-10T11:37:56Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3379

acs-robot · 2022-05-11T06:13:51Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-05-11T06:15:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

sureshanaparti · 2022-05-11T06:16:29Z

Hi @rohityadavcloud No UI changes in this PR, but bot detected UI changes. Can you check/fix it. Thanks.

blueorangutan · 2022-05-11T06:20:17Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6367 (SL-JID-1546)

core/src/main/java/com/cloud/agent/api/ModifyStoragePoolCommand.java

...ns/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java

...o/src/main/java/org/apache/cloudstack/storage/datastore/client/ScaleIOGatewayClientImpl.java

.../main/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriver.java

...java/org/apache/cloudstack/storage/datastore/lifecycle/ScaleIOPrimaryDataStoreLifeCycle.java

...leio/src/main/java/org/apache/cloudstack/storage/datastore/provider/ScaleIOHostListener.java

...e/volume/scaleio/src/main/java/org/apache/cloudstack/storage/datastore/util/ScaleIOUtil.java

DaanHoogland

agree with mosat of @GutoVeronezi ś comments, but generally lgtm

sureshanaparti · 2022-05-17T05:22:21Z

@GutoVeronezi thanks for the review. addressed the review comments, please check.

sureshanaparti · 2022-05-17T05:22:41Z

@blueorangutan package

blueorangutan · 2022-05-17T05:23:02Z

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-05-17T06:01:07Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3418

sureshanaparti · 2022-05-17T06:03:13Z

@blueorangutan test

blueorangutan · 2022-06-20T07:09:05Z

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-06-20T09:23:38Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✖️ suse15. SL-JID 3593

sureshanaparti · 2022-06-20T09:51:51Z

@blueorangutan test

blueorangutan · 2022-06-20T09:53:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-06-20T20:29:07Z

Trillian test result (tid-4338)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36727 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6367-t4338-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

acs-robot · 2022-06-21T04:32:23Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-21T04:33:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

…) network for Hosts(KVM) SDC connection.

sureshanaparti · 2022-06-21T04:37:47Z

@blueorangutan package

blueorangutan · 2022-06-21T04:38:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-06-21T04:44:36Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6367 (SL-JID-1786)

sonarqubecloud · 2022-06-21T05:46:11Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells

15.0% Coverage
0.0% Duplication

blueorangutan · 2022-06-21T05:58:11Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3606

yadvr · 2022-06-21T09:35:11Z

@blueorangutan test

blueorangutan · 2022-06-21T09:36:03Z

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-06-21T09:45:46Z

Trillian Build Failed (tid-4345)

sureshanaparti · 2022-06-21T10:41:37Z

@blueorangutan test

blueorangutan · 2022-06-21T10:42:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-06-21T21:23:17Z

Trillian test result (tid-4346)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36917 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6367-t4346-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

boring-cyborg bot added component:api component:iscsi component:kvm component:primary-storage component:storage labels May 9, 2022

sureshanaparti force-pushed the seperate-host-network-support-for-scaleio-storage branch from 05006e4 to 6cdad85 Compare May 9, 2022 11:08

apache deleted a comment from blueorangutan May 9, 2022

GutoVeronezi reviewed May 11, 2022

View reviewed changes

DaanHoogland approved these changes May 16, 2022

View reviewed changes

sureshanaparti force-pushed the seperate-host-network-support-for-scaleio-storage branch from b06b7e6 to 46b94ee Compare May 17, 2022 05:20

yadvr added this to the 4.17.1.0 milestone Jun 20, 2022

sureshanaparti force-pushed the seperate-host-network-support-for-scaleio-storage branch from 2de2248 to 9aafcc5 Compare June 21, 2022 04:30

boring-cyborg bot added component:agent component:build component:orchestration distro:ubuntu labels Jun 21, 2022

sureshanaparti changed the base branch from main to 4.17 June 21, 2022 04:31

sureshanaparti added 3 commits June 21, 2022 10:05

Updated PowerFlex/ScaleIO storage plugin to support separate (storage…

3bb9d52

…) network for Hosts(KVM) SDC connection.

Fixes for code smells

650088d

Review changes

44d33ce

sureshanaparti force-pushed the seperate-host-network-support-for-scaleio-storage branch from 9aafcc5 to 44d33ce Compare June 21, 2022 04:36

yadvr merged commit c70bc9d into apache:4.17 Jun 27, 2022

Updated PowerFlex/ScaleIO storage plugin to support separate (storage) network for Hosts(KVM)/Storage connection. #6367

Updated PowerFlex/ScaleIO storage plugin to support separate (storage) network for Hosts(KVM)/Storage connection. #6367

Uh oh!

Conversation

sureshanaparti commented May 9, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

sureshanaparti commented May 9, 2022

Uh oh!

blueorangutan commented May 9, 2022

Uh oh!

sureshanaparti commented May 9, 2022

Uh oh!

blueorangutan commented May 9, 2022

Uh oh!

blueorangutan commented May 9, 2022

Uh oh!

sureshanaparti commented May 9, 2022

Uh oh!

blueorangutan commented May 9, 2022

Uh oh!

blueorangutan commented May 9, 2022

Uh oh!

sureshanaparti commented May 10, 2022

Uh oh!

blueorangutan commented May 10, 2022

Uh oh!

blueorangutan commented May 10, 2022

Uh oh!

acs-robot commented May 11, 2022

Uh oh!

blueorangutan commented May 11, 2022

Uh oh!

sureshanaparti commented May 11, 2022

Uh oh!

blueorangutan commented May 11, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented May 17, 2022

Uh oh!

sureshanaparti commented May 17, 2022

Uh oh!

blueorangutan commented May 17, 2022

Uh oh!

blueorangutan commented May 17, 2022

Uh oh!

sureshanaparti commented May 17, 2022

Uh oh!

blueorangutan commented Jun 20, 2022

Uh oh!

blueorangutan commented Jun 20, 2022

Uh oh!

sureshanaparti commented Jun 20, 2022

Uh oh!

blueorangutan commented Jun 20, 2022

Uh oh!

blueorangutan commented Jun 20, 2022

Uh oh!

acs-robot commented Jun 21, 2022

Uh oh!

blueorangutan commented Jun 21, 2022

Uh oh!