UI: Fix template is deselected if other zone is selected #6415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvazquez
requested review from
Pearl1594,
shwstppr,
slavkap,
utchoang and
weizhouapache
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
| }, | ||
| methods: { | ||
| updateTemplateKey () { | ||
| this.templateKey += 1 |
Member
There was a problem hiding this comment.
check if templateKey method receives an arg?
Contributor
Author
There was a problem hiding this comment.
Sorry @rohityadavcloud I don't understand why to check for an arg in this case, you mean to extend the method and increment only when an arg is passed?
Pearl1594
approved these changes
May 30, 2022
Contributor
Pearl1594
left a comment
Pearl1594
left a comment
There was a problem hiding this comment.
LGTM. Tested - selects template on zone selection change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a minor UI issue on multiple zones:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?