Skip to content

UI: fix create vpc private gw by regular users #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvazquez merged 1 commit into from
Jun 9, 2022
Merged

UI: fix create vpc private gw by regular users #6445

nvazquez merged 1 commit into from
Jun 9, 2022

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Jun 8, 2022

Description

This PR fixes an regression issue of #6400

Ths issue is, the associated network is always required, even when a network is selected from the drop down, which cause regular users arenot able to create private gateway with associated network.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache changed the base branch from main to 4.17 June 8, 2022 14:46
@weizhouapache weizhouapache added this to the 4.17.1.0 milestone Jun 8, 2022
@acs-robot
Copy link

acs-robot commented Jun 8, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jun 8, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jun 8, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6445 (SL-JID-1697)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sureshanaparti
sureshanaparti approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@nvazquez nvazquez merged commit d45d257 into apache:4.17 Jun 9, 2022
@weizhouapache weizhouapache deleted the 4.17-fix-user-create-privategw branch December 9, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@utchoang utchoang utchoang approved these changes

Assignees

No one assigned

Labels

component:UI type:bug

Projects

None yet

Milestone

4.17.1.0

Development

Successfully merging this pull request may close these issues.

8 participants

@weizhouapache @acs-robot @blueorangutan @shwstppr @nvazquez @Pearl1594 @sureshanaparti @utchoang