Skip to content

Comments

api: Add vpc name and uuid to VMs list response (nics) and nics response#6454

Closed
Pearl1594 wants to merge 0 commit intoapache:4.17from
shapeblue:add-vpc-info-to-vms-nics
Closed

api: Add vpc name and uuid to VMs list response (nics) and nics response#6454
Pearl1594 wants to merge 0 commit intoapache:4.17from
shapeblue:add-vpc-info-to-vms-nics

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR adds vpc info to the nics response as part of list VMs response and list nics response
Addresses: #6452

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

listed VMs and nics for a VM belonging to a VPC network:

(localcloud) 🐱 > list virtualmachines id=9c762cf8-7742-48df-bc57-43bf126d3471 filter=nic,
{
  "count": 1,
  "virtualmachine": [
    {
      "nic": [
        {
          "broadcasturi": "vlan://167",
          "deviceid": "0",
          "extradhcpoption": [],
          "gateway": "10.10.10.1",
          "id": "a703d827-4b5a-46e4-b9ea-8cd2aaafbc26",
          "ipaddress": "10.10.10.66",
          "isdefault": true,
          "isolationuri": "vlan://167",
          "macaddress": "02:00:28:aa:00:01",
          "netmask": "255.255.255.0",
          "networkid": "02ad6bac-1cd6-461a-a951-8934bffd4eb9",
          "networkname": "n1",
          "secondaryip": [],
          "traffictype": "Guest",
          "type": "Isolated",
          "vpcid": "e74c44c9-aad7-4c0e-adbe-912d980c2f28",
          "vpcname": "v1"
        }
      ]
    }
  ]
}

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3568

@Pearl1594
Copy link
Contributor Author

@blueorangutan test

@Pearl1594 Pearl1594 requested review from nvazquez and shwstppr June 15, 2022 11:32
@Pearl1594 Pearl1594 added this to the 4.17.1.0 milestone Jun 15, 2022
@blueorangutan
Copy link

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez
Copy link
Contributor

@Pearl1594 can you please rebase and target to the 4.17 branch?

@Pearl1594 Pearl1594 changed the base branch from main to 4.17 June 15, 2022 16:02
@Pearl1594 Pearl1594 changed the base branch from 4.17 to main June 15, 2022 16:02
@Pearl1594 Pearl1594 force-pushed the add-vpc-info-to-vms-nics branch from ccd4f9b to 5d43cde Compare June 15, 2022 16:04
@Pearl1594 Pearl1594 changed the base branch from main to 4.17 June 15, 2022 16:04
@Pearl1594 Pearl1594 closed this Jun 15, 2022
@Pearl1594 Pearl1594 force-pushed the add-vpc-info-to-vms-nics branch from 5d43cde to aae0fae Compare June 15, 2022 16:05
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

10.0% 10.0% Coverage
0.0% 0.0% Duplication

@blueorangutan
Copy link

Trillian test result (tid-4322)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42216 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6454-t4322-kvm-centos7.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 462.77 test_vpc_redundant.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants