Skip to content

UI fix message.add.vpn.customer.gateway.failed when catched error#6493

Merged
shwstppr merged 3 commits intoapache:4.17from
hooklee2000:4.17
Jun 28, 2022
Merged

UI fix message.add.vpn.customer.gateway.failed when catched error#6493
shwstppr merged 3 commits intoapache:4.17from
hooklee2000:4.17

Conversation

@hooklee2000
Copy link
Copy Markdown
Contributor

@hooklee2000 hooklee2000 commented Jun 24, 2022

Description

As 4.17.0.0,when catched error, we changed message.success.add.vpn.customer.gateway to
message.add.vpn.customer.gateway.failed.

fix UI VPC add ACL without required input close ui
Without any input, click ok button then close the ui . We need display ui to confirm all required input.

changed the base branch of the PR to 4.17 and rebase your PR branch to the 4.17 branch
link #6489

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6493 (SL-JID-1829)

Without any input, click ok button then close the ui . We need display ui to confirm all required input.
@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@hooklee2000
Copy link
Copy Markdown
Contributor Author

fix UI VPC add ACL without required input close ui

Without any input, click ok button then close the ui . We need display ui to confirm all required input.

@blueorangutan
Copy link
Copy Markdown

UI build: ✖️
(SL-JID-1830)

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2022-06-24 12-42-35
Fix works

@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6493 (SL-JID-1833)

@shwstppr shwstppr requested review from Pearl1594 and yadvr June 24, 2022 08:31
@DaanHoogland DaanHoogland added this to the 4.17.1.0 milestone Jun 27, 2022
@shwstppr shwstppr merged commit aee7bb9 into apache:4.17 Jun 28, 2022
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Jun 28, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants