Remove psudo jobs from listAsyncJobs API

[davidjumani]

Description

Removes psudo job results from the response of the listAsyncJobs API

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

Before :

(localhost) 🐱 > list asyncjobs listall=true filter=jobid,jobinstancetype,
{
  "asyncjobs": [
    {
      "jobid": "27ed55c7-419d-4c69-acfc-496e6f85266a"      <- Psudo job
    },
    {
      "jobid": "3d616d8f-f8ca-413d-a622-25f579137f14"      <- Psudo job
    },
    {
      "jobid": "202fed87-fde7-476e-a829-8d3b39167019"      <- Psudo job
    },
    {
      "jobid": "202fed87-5f85-4767-a622-ee39be729451"      <- Psudo job
    }
    {
      "jobid": "ae46b9e7-d315-4795-bc24-a1fb4bd4ec73",
      "jobinstancetype": "VirtualMachine"
    }
  ],
  "count": 5
}

After :

(localhost) 🐱 > list asyncjobs listall=true filter=jobid,jobinstancetype,
{
  "asyncjobs": [
    {
      "jobid": "eba01225-7029-4730-96e1-b9d38c916657",
      "jobinstancetype": "VirtualMachine"
    }
  ],
  "count": 1
}

[davidjumani]

@blueorangutan package

[blueorangutan]

@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3812

[davidjumani]

@blueorangutan test

[blueorangutan]

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4533)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39046 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6564-t4533-kvm-centos7.zip
Smoke tests completed. 99 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	560.13	test_kubernetes_clusters.py

[shwstppr]

@davidjumani as this is a bugfix should this go in 4.17?

[davidjumani]

@blueorangutan package

[blueorangutan]

@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[davidjumani]

Updated the base @shwstppr

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6564 (SL-JID-1999)

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3823

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4542)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38834 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6564-t4542-kvm-centos7.zip
Smoke tests completed. 99 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	544.96	test_kubernetes_clusters.py

[sureshanaparti]

code LGTM

[harikrishna-patnala]

LGTM

[shwstppr]

Tested with and without this change

Without change (A volume migration is in progress):

(localcloud) 🐱 > list asyncjobs listall=true
{
  "asyncjobs": [
    {
      "accountid": "49ab4525-f71a-11ec-87b5-1e0057000461",
      "created": "2022-06-29T11:18:06+0000",
      "jobid": "bde2a196-8e6e-490c-8453-1e5d4dc36971",
      "jobprocstatus": 0,
      "jobresultcode": 0,
      "jobstatus": 0,
      "userid": "49ab5232-f71a-11ec-87b5-1e0057000461"
    },
    {
      "accountid": "49ab4525-f71a-11ec-87b5-1e0057000461",
      "created": "2022-06-29T11:18:06+0000",
      "jobid": "bec2ae08-696b-4bc7-a509-944659f1adb0",
      "jobprocstatus": 0,
      "jobresultcode": 0,
      "jobstatus": 0,
      "userid": "49ab5232-f71a-11ec-87b5-1e0057000461"
    },
    {
      "accountid": "49ac12a3-f71a-11ec-87b5-1e0057000461",
      "cmd": "org.apache.cloudstack.api.command.admin.volume.MigrateVolumeCmdByAdmin",
      "created": "2022-07-27T06:25:55+0000",
      "jobid": "4711fb07-f038-4021-9dbb-5f2eadc3f030",
      "jobinstanceid": "05dd1e62-d2f3-46d8-bd39-401f70941b6f",
      "jobinstancetype": "Volume",
      "jobprocstatus": 0,
      "jobresultcode": 0,
      "jobstatus": 0,
      "userid": "49ad4079-f71a-11ec-87b5-1e0057000461"
    },
    {
      "accountid": "49ac12a3-f71a-11ec-87b5-1e0057000461",
      "cmd": "com.cloud.vm.VmWorkMigrateVolume",
      "created": "2022-07-27T06:25:55+0000",
      "jobid": "286823ce-df79-49e6-886e-91da9eab16fd",
      "jobprocstatus": 0,
      "jobresultcode": 0,
      "jobstatus": 0,
      "userid": "49ad4079-f71a-11ec-87b5-1e0057000461"
    }
  ],
  "count": 4
}

With change (Again a volume migration is in progress):

(localcloud) 🐱 > list asyncjobs listall=true
{
  "asyncjobs": [
    {
      "accountid": "49ac12a3-f71a-11ec-87b5-1e0057000461",
      "cmd": "org.apache.cloudstack.api.command.admin.volume.MigrateVolumeCmdByAdmin",
      "created": "2022-07-27T07:07:58+0000",
      "jobid": "8f52f1ed-920e-429a-a45b-bb0e9eab7072",
      "jobinstanceid": "05dd1e62-d2f3-46d8-bd39-401f70941b6f",
      "jobinstancetype": "Volume",
      "jobprocstatus": 0,
      "jobresultcode": 0,
      "jobstatus": 0,
      "userid": "49ad4079-f71a-11ec-87b5-1e0057000461"
    }
  ],
  "count": 1
}