Skip to content

UI: Fix account limits values reset after focus is lost on fields#6578

Merged
nvazquez merged 1 commit intoapache:4.17from
shapeblue:fixaccountlimitsuiissue
Jul 28, 2022
Merged

UI: Fix account limits values reset after focus is lost on fields#6578
nvazquez merged 1 commit intoapache:4.17from
shapeblue:fixaccountlimitsuiissue

Conversation

@nvazquez
Copy link
Contributor

Description

Fixes: #6576

Screen Shot 2022-07-27 at 11 53 57

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Account -> Configure limits working as expected

@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6578 (SL-JID-2014)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez similar code is there in a few other files, should they be changed too?

ui/src/views/compute/wizard/NetworkConfiguration.vue
ui/src/views/infra/network/ServiceProvidersTab.vue

Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvazquez nvazquez merged commit b00c507 into apache:4.17 Jul 28, 2022
@nvazquez
Copy link
Contributor Author

Thanks @shwstppr will post another PR for those files so we can test them

@nvazquez
Copy link
Contributor Author

@shwstppr I have verified that the NetworkConfiguration.vue is not affected but there is an issue with ServiceProvidersTab, for which I have created the PR #6583

neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Account (and possible domain) configure limits reset value on click away

5 participants