api: fix ipv6 firewall apis default role permissions by shwstppr · Pull Request #6579 · apache/cloudstack

shwstppr · 2022-07-27T16:50:34Z

Description

Fixes default roles permissions for IPv6 firewall related APIs
Refactors related marvin tests to call deploy, update, restart network and VM APIs as user instead of the admin
Fixes #6575

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Fixes apache#6575 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

acs-robot · 2022-07-27T16:51:37Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-07-27T16:52:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-07-27T16:57:29Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6579 (SL-JID-2017)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

acs-robot · 2022-07-27T17:21:19Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-07-27T17:22:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

acs-robot · 2022-07-27T17:26:53Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-07-27T17:27:21Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6579 (SL-JID-2018)

shwstppr · 2022-07-27T17:28:39Z

@blueorangutan package

blueorangutan · 2022-07-27T17:29:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-07-27T18:06:01Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3840

shwstppr · 2022-07-27T20:24:55Z

@blueorangutan test

blueorangutan · 2022-07-27T20:26:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-07-28T08:42:30Z

Trillian test result (tid-4553)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42868 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6579-t4553-kvm-centos7.zip
Smoke tests completed. 98 look OK, 2 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	552.34	test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	458.82	test_vpc_redundant.py

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

sonarqubecloud · 2022-07-29T07:34:23Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

shwstppr · 2022-07-29T07:56:38Z

@blueorangutan package

blueorangutan · 2022-07-29T07:57:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-07-29T08:37:46Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3853

sureshanaparti · 2022-07-29T11:52:59Z

@blueorangutan test

blueorangutan · 2022-07-29T11:54:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-07-29T12:05:33Z

Trillian Build Failed (tid-4567)

weizhouapache

code lgtm

@shwstppr are the two test_network_ipv6.py same ?

shwstppr · 2022-07-29T12:13:40Z

@weizhouapache no. The file under component tests has more number of tests

yadvr · 2022-07-29T12:13:42Z

@blueorangutan test

blueorangutan · 2022-07-29T12:14:03Z

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-07-29T12:25:02Z

Trillian Build Failed (tid-4569)

shwstppr · 2022-07-29T12:53:01Z

@blueorangutan test

blueorangutan · 2022-07-29T12:54:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-07-29T13:04:46Z

Trillian Build Failed (tid-4573)

shwstppr · 2022-07-30T07:13:38Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-07-30T07:14:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2022-07-30T19:04:41Z

Trillian test result (tid-4574)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41440 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6579-t4574-vmware-67u3.zip
Smoke tests completed. 100 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Fixes apache#6575 * fixes ipv6 firewall apis default role permissions * test: use user apiclient for ipv6 firewall apis Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

api: fix ipv6 firewall apis role permissions

422c655

Fixes apache#6575 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg bot added component:api component:ipv6 component:UI labels Jul 27, 2022

shwstppr added this to the 4.17.1.0 milestone Jul 27, 2022

test: use user apiclient for ipv6 firewall apis

1dfdd68

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Jul 27, 2022

revert

efddd3c

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr linked an issue Jul 27, 2022 that may be closed by this pull request

Missing IPV6 Firewall in UI User view #6575

Closed

shwstppr marked this pull request as ready for review July 29, 2022 04:39

test: make network, vm api calls as user

293ef4f

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr self-assigned this Jul 29, 2022

apache deleted a comment from acs-robot Jul 29, 2022

apache deleted a comment from blueorangutan Jul 29, 2022

shwstppr requested a review from nvazquez July 29, 2022 07:08

shwstppr requested a review from weizhouapache July 29, 2022 07:08

weizhouapache approved these changes Jul 29, 2022

View reviewed changes

yadvr approved these changes Jul 29, 2022

View reviewed changes

shwstppr merged commit 9a264c1 into apache:4.17 Jul 31, 2022

Conversation

shwstppr commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

acs-robot commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 27, 2022

Uh oh!

acs-robot commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 27, 2022

Uh oh!

acs-robot commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 27, 2022

Uh oh!

shwstppr commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 27, 2022

Uh oh!

shwstppr commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 28, 2022

Uh oh!

sonarqubecloud bot commented Jul 29, 2022

Uh oh!

shwstppr commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

sureshanaparti commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jul 29, 2022

Uh oh!

yadvr commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

shwstppr commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

shwstppr commented Jul 30, 2022

Uh oh!

blueorangutan commented Jul 30, 2022

Uh oh!

blueorangutan commented Jul 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

shwstppr commented Jul 27, 2022 •

edited

Loading