Skip to content

ui: fix update network updateinsequence param#6675

Merged
shwstppr merged 1 commit intoapache:4.17from
shapeblue:fix-ui-updatenetworkupdateinseq
Aug 26, 2022
Merged

ui: fix update network updateinsequence param#6675
shwstppr merged 1 commit intoapache:4.17from
shapeblue:fix-ui-updatenetworkupdateinseq

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

Description

Fixes wrong param used in the update network form

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6675 (SL-JID-2230)

@shwstppr shwstppr changed the title ui: fix update network update in sequence param ui: fix update network updateinsequence param Aug 26, 2022
Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2022

Codecov Report

Merging #6675 (0361960) into 4.17 (7ddebd3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.17    #6675      +/-   ##
============================================
- Coverage      5.86%    5.86%   -0.01%     
+ Complexity     3920     3918       -2     
============================================
  Files          2451     2451              
  Lines        242282   242282              
  Branches      37911    37911              
============================================
- Hits          14211    14207       -4     
- Misses       226501   226505       +4     
  Partials       1570     1570              
Impacted Files Coverage Δ
...apache/cloudstack/syslog/AlertsSyslogAppender.java 56.49% <0.00%> (-2.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shwstppr shwstppr merged commit 7115e35 into apache:4.17 Aug 26, 2022
@shwstppr shwstppr added this to the 4.17.1.0 milestone Aug 26, 2022
neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Sep 5, 2022
Fixes wrong param used in the update network form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants