-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ui: Fix netowrkid not passed in deployvm #6711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## 4.17 #6711 +/- ##
=======================================
Coverage ? 5.88%
Complexity ? 3928
=======================================
Files ? 2451
Lines ? 242338
Branches ? 37923
=======================================
Hits ? 14263
Misses ? 226499
Partials ? 1576 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
NuxRo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm








Description
Fixes the issue of the networkid not being passed when deploying a VM
This is caused when the first template selected is a deploy-as-is one and the
nicToNetworkSelectionnot being reset when selecting a new templateTypes of changes
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?