Skip to content

Conversation

@davidjumani
Copy link
Contributor

Description

Fixes the issue of the networkid not being passed when deploying a VM
This is caused when the first template selected is a deploy-as-is one and the nicToNetworkSelection not being reset when selecting a new template

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6711 (SL-JID-2306)

@shwstppr shwstppr requested a review from utchoang September 7, 2022 04:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shwstppr shwstppr requested a review from Pearl1594 September 7, 2022 05:47
@shwstppr shwstppr added this to the 4.17.1.0 milestone Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (4.17@c4c4c71). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             4.17    #6711   +/-   ##
=======================================
  Coverage        ?    5.88%           
  Complexity      ?     3928           
=======================================
  Files           ?     2451           
  Lines           ?   242338           
  Branches        ?    37923           
=======================================
  Hits            ?    14263           
  Misses          ?   226499           
  Partials        ?     1576           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shwstppr shwstppr merged commit f342cf3 into apache:4.17 Sep 7, 2022
@davidjumani davidjumani deleted the fix-networkid-deployvm branch September 7, 2022 07:30
weizhouapache added a commit that referenced this pull request Sep 7, 2022
ui: fix zone icon in vm deploy zone selection (#6543)
ui: remove incorrect API calls when initializing the deploy VM page (#6687)
ui: Fix netowrkid not passed in deployvm (#6711)
Copy link
Contributor

@NuxRo NuxRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants