allow a new upgrade version without DB changes to be inserted #6858

DaanHoogland · 2022-10-31T07:45:06Z

Description

This PR...

Fixes: #6760

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

unit tests (so far)

acs-robot · 2022-10-31T07:46:21Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-10-31T07:47:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-10-31T07:52:56Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6858 (SL-JID-2597)

DaanHoogland · 2022-10-31T08:42:33Z

@blueorangutan package

acs-robot · 2022-10-31T08:42:56Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-10-31T08:43:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

engine/schema/src/test/java/com/cloud/upgrade/DatabaseUpgradeCheckerTest.java

acs-robot · 2022-10-31T09:31:14Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-10-31T09:31:52Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4593

blueorangutan · 2022-10-31T09:32:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-10-31T09:37:35Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6858 (SL-JID-2598)

acs-robot · 2022-10-31T12:19:42Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-10-31T12:20:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-10-31T12:25:34Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6858 (SL-JID-2599)

DaanHoogland · 2022-10-31T14:20:42Z

@blueorangutan package

blueorangutan · 2022-10-31T14:21:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

acs-robot · 2022-10-31T14:23:14Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-10-31T14:24:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-10-31T14:25:50Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4594

weizhouapache · 2022-11-02T14:57:29Z

engine/schema/src/test/java/com/cloud/upgrade/DatabaseVersionHierarchyTest.java

+import java.io.InputStream;
+import java.sql.Connection;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;


@DaanHoogland
what's the difference between this and Assert.assertEquals ?

this is junit5 as opposed to junit4

blueorangutan · 2022-11-03T00:18:11Z

Trillian test result (tid-15)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42791 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6858-t15-kvm-centos7.zip
Smoke tests completed. 102 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	412.45	test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn	`Failure`	778.64	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Error`	1277.60	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Error`	552.88	test_vpc_vpn.py

DaanHoogland · 2022-12-02T09:39:26Z

@blueorangutan package

blueorangutan · 2022-12-02T09:40:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-12-02T11:03:37Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✖️ suse15. SL-JID 4742

blueorangutan · 2022-12-02T13:46:17Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 4747

blueorangutan · 2022-12-02T15:47:13Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 4749

blueorangutan · 2022-12-09T11:16:53Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4826

DaanHoogland · 2022-12-12T08:55:06Z

@blueorangutan test

blueorangutan · 2022-12-12T08:56:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-12-12T20:35:17Z

Trillian test result (tid-5466)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40576 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6858-t5466-kvm-centos7.zip
Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2022-12-12T21:08:18Z

engine/schema/pom.xml

+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <version>5.9.1</version>


@DaanHoogland
Can you move the version to pom.xml ?

Others looks good to me

weizhouapache · 2022-12-14T18:53:13Z

@blueorangutan package

blueorangutan · 2022-12-14T18:54:05Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-12-14T20:22:33Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4946

blueorangutan · 2022-12-16T08:34:50Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4979

DaanHoogland

semantic conflict :(

engine/schema/src/test/java/com/cloud/upgrade/DatabaseVersionHierarchyTest.java

weizhouapache · 2022-12-16T08:53:54Z

@blueorangutan package

blueorangutan · 2022-12-16T08:55:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-12-16T10:57:54Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4981

blueorangutan · 2022-12-16T11:12:07Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4990

DaanHoogland · 2022-12-16T13:51:34Z

@blueorangutan test

blueorangutan · 2022-12-16T13:52:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-12-17T01:24:30Z

Trillian test result (tid-5532)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40229 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6858-t5532-kvm-centos7.zip
Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

allow a new upgrade version without DB changes to be inserted

82a696a

extraTests

e2bff55

boring-cyborg bot added the component:build label Oct 31, 2022

DaanHoogland requested a review from yadvr October 31, 2022 08:42

DaanHoogland commented Oct 31, 2022

View reviewed changes

engine/schema/src/test/java/com/cloud/upgrade/DatabaseUpgradeCheckerTest.java Outdated Show resolved Hide resolved

DaanHoogland added component:upgrade component:database and removed component:build labels Oct 31, 2022

change assertion

8429579

boring-cyborg bot added the component:build label Oct 31, 2022

rats

e9bb9ec

sonar

410f632

weizhouapache reviewed Nov 2, 2022

View reviewed changes

DaanHoogland marked this pull request as ready for review December 12, 2022 11:25

weizhouapache reviewed Dec 12, 2022

View reviewed changes

weizhouapache approved these changes Dec 12, 2022

View reviewed changes

DaanHoogland mentioned this pull request Dec 14, 2022

SystemVM Template Upgrade doesn't kick in for NoopDbUpgrade #6980

Closed

version in parent pom

823e6f2

DaanHoogland commented Dec 16, 2022

View reviewed changes

engine/schema/src/test/java/com/cloud/upgrade/DatabaseVersionHierarchyTest.java Outdated Show resolved Hide resolved

engine/schema/src/test/java/com/cloud/upgrade/DatabaseVersionHierarchyTest.java Outdated Show resolved Hide resolved

update updated versions

c99c0bc

DaanHoogland merged commit 41717b0 into apache:main Dec 19, 2022

allow a new upgrade version without DB changes to be inserted #6858

allow a new upgrade version without DB changes to be inserted #6858

Uh oh!

Conversation

DaanHoogland commented Oct 31, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

acs-robot commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

DaanHoogland commented Oct 31, 2022

Uh oh!

acs-robot commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

Uh oh!

acs-robot commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

acs-robot commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

DaanHoogland commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

acs-robot commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

blueorangutan commented Oct 31, 2022

Uh oh!

weizhouapache Nov 2, 2022

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Nov 3, 2022

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Nov 3, 2022

Uh oh!

DaanHoogland commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 9, 2022

Uh oh!

DaanHoogland commented Dec 12, 2022

Uh oh!

blueorangutan commented Dec 12, 2022

Uh oh!

blueorangutan commented Dec 12, 2022

Uh oh!

weizhouapache Dec 12, 2022

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Dec 14, 2022