Skip to content

Conversation

@jbampton
Copy link
Member

flake8 --select=W291,W292,W293,W391 .

./test/integration/smoke/test_register_userdata.py:766:1: W391 blank line at end of file

./test/integration/component/test_network_vpc_custom_dns.py:732:1: W391 blank line at end of file

Description

This PR fixes the flake8 test

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

flake8 --select=W291,W292,W293,W391 .

./test/integration/smoke/test_register_userdata.py:766:1: W391 blank line at end of file

./test/integration/component/test_network_vpc_custom_dns.py:732:1: W391 blank line at end of file
@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Nov 13, 2022
@DaanHoogland
Copy link
Contributor

@jbampton are you running these tests locally? they are not run in any of the travis jobs.

@jbampton
Copy link
Member Author

Yes I run flake8 locally. But it runs with the GitHub Actions SuperLinter Check on modified files only on pull requests:

https://github.com/apache/cloudstack/actions/runs/3454836056/jobs/5766433087

@jbampton
Copy link
Member Author

In future we could add flake8 to pre-commit to allow everyone to run the tests locally on git commit.

There is another pull request where I was adding the first check with pre-commit.

refs #6273

@DaanHoogland
Copy link
Contributor

daring to go against principle on this one, only empty lines on end of files

@DaanHoogland DaanHoogland merged commit 60420b0 into apache:main Nov 13, 2022
@jbampton jbampton deleted the python-blank-lines branch November 13, 2022 10:45
@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants