Enable CPU cap in VRs if the offering has a CPU cap limitation

[SadiJr]

Description

When deploying a new VR, using a network offering with CPU cap, this limitation is not respected in the VR, because in the definition and persistence of VR in database, the configuration of CPU cap of the network offering is not considered, and always uses the value false. This PR aims to fix this behavior, to respect the CPU cap of the network offering.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

It was tested in a local lab:

1. I created new isolated networks, and also created new VMs that use they;
2. I executed an dumpxml in the VR definition;
3. Before, the XML of the VR does not have the cpushared tag;
4. Now, the definition of the VR have the cpushares tag, when using a network offering with CPU cap.

[codecov]

Codecov Report

Merging #7234 (c69124b) into main (2f309b5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #7234      +/-   ##
============================================
- Coverage     12.95%   12.95%   -0.01%     
  Complexity     8986     8986              
============================================
  Files          2728     2728              
  Lines        256647   256648       +1     
  Branches      40024    40024              
============================================
  Hits          33256    33256              
- Misses       219214   219215       +1     
  Partials       4177     4177              

Impacted Files	Coverage Δ
...va/com/cloud/network/router/NetworkHelperImpl.java	3.81% <0.00%> (-0.01%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[DaanHoogland]

CLGTM

[DaanHoogland]

@ezntt please comment on why you approve. Did you test/review and if test, how?

[ezntt]

Sure, @DaanHoogland, I approve the feature based on my testing, which was carried out using a similar approach to the PR owner.

I tested the change by creating a VR and verifying its dumpxml to confirm that cpushares tag was set correctly. Specifically, I confirmed that the tag:

<cputune>
    <shares>500</shares> 
</cputune>

were properly defined, which confirmed that the change was successful.

[weizhouapache]

code lgtm

[DaanHoogland]

Sure, @DaanHoogland, I approve the feature based on my testing, which was carried out using a similar approach to the PR owner.

I tested the change by creating a VR and verifying its dumpxml to confirm that cpushares tag was set correctly. Specifically, I confirmed that the tag:

<cputune>
    <shares>500</shares> 
</cputune>

were properly defined, which confirmed that the change was successful.

Great work @ezntt , we have a rule to have at least one lgtm based on code review and one lgtm based on 3rd party testing. Hence my question.

[stephankruggg]

CLGTM, not manually tested

[kiranchavala]

@SadiJr @DaanHoogland

I have performed a manual test on 4.17.2 release and I observe that cpu cap is honoured

Let me know if any step is missing in reproducing the issue ?

Steps that I have followed

1. Create router with the default system offering

Login to the kvm host where the router is running and execute

virsh dumpxml <>

 <cputune>
    <shares>250</shares>
  </cputune>

2. Create a system offering with cpu-cap enabled

3. Change the global setting value of "router.service.offering" to the uuid of system offering with cpu-cap enabled

4. Create a router with the new system offering for router with cpu-cap

Observer the cpushare tag is present

virsh dumpxml <>

  <cputune>
    <shares>256</shares>
  </cputune>

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6127