Skip to content

[Cleanup] removed commented code in DhcpProtocolParserServer.java#7488

Merged
yadvr merged 1 commit intoapache:mainfrom
nikam14:patch-3
May 23, 2023
Merged

[Cleanup] removed commented code in DhcpProtocolParserServer.java#7488
yadvr merged 1 commit intoapache:mainfrom
nikam14:patch-3

Conversation

@nikam14
Copy link
Contributor

@nikam14 nikam14 commented May 2, 2023

Description

This PR... removed commented code.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #7488 (f718052) into main (8b5bfb1) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7488      +/-   ##
============================================
- Coverage     12.72%   12.71%   -0.01%     
+ Complexity     8706     8705       -1     
============================================
  Files          2727     2727              
  Lines        256526   256526              
  Branches      39989    39989              
============================================
- Hits          32636    32627       -9     
- Misses       219738   219748      +10     
+ Partials       4152     4151       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weizhouapache weizhouapache changed the title [Enhancement] removed commented code in DhcpProtocolParserServer.java [Cleanup] removed commented code in DhcpProtocolParserServer.java May 12, 2023
@yadvr yadvr added this to the 4.19.0.0 milestone May 23, 2023
@yadvr yadvr merged commit c9b103c into apache:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants