-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Updated the code to access the primary color from config.json. #7532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lue instead of accessing it from @primary-color in config.json file. Updated the code to access the primary color from config.json
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build failed: ✖️ |
Codecov Report
@@ Coverage Diff @@
## main #7532 +/- ##
=========================================
Coverage 12.95% 12.95%
- Complexity 8986 8987 +1
=========================================
Files 2728 2728
Lines 256647 256647
Branches 40024 40024
=========================================
+ Hits 33256 33258 +2
+ Misses 219214 219208 -6
- Partials 4177 4181 +4 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
Is there anything else that i have to do? |
@ilhamalrahm , You need a second LGTM and test verification. Best is to look at |
|
@davidjumani and @utchoang worked last in that area. How can i request for a review? |
ok, these are not currently active on the project @shwstppr can you review? |
|
Anything i can do? |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Awesome work, congrats on your first merged pull request! |


This PR is related to the issue #7056.
backgroundColor of user-menu-avatar was hardcoded to primary color value instead of accessing it from @primary-color in config.json file.
Description
This PR resolves #7056.
backgroundColor of user-menu-avatar was hardcoded to primary color value instead of accessing @primary-color in config.json file.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?