Fix haproxy log rotation in VR system VM

[vdombrovski]

Description

This PR fixes #7576

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Change tested by modifiying the logrotation config directly on the SystemVM

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6082

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[codecov]

Codecov Report

Merging #7587 (e604d27) into 4.17 (ea2b537) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #7587   +/-   ##
=========================================
  Coverage     10.38%   10.38%           
  Complexity     6648     6648           
=========================================
  Files          2453     2453           
  Lines        242467   242467           
  Branches      37943    37943           
=========================================
  Hits          25170    25170           
  Misses       214178   214178           
  Partials       3119     3119           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[weizhouapache]

same command as #4869, it should be good.

[weizhouapache]

@vdombrovski
can you rebase with 4.17 branch, and re-target to 4.17 ?

[blueorangutan]

[SF] Trillian test result (tid-6677)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42977 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7587-t6677-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[vdombrovski]

@vdombrovski can you rebase with 4.17 branch, and re-target to 4.17 ?

Done

[weizhouapache]

@vdombrovski can you rebase with 4.17 branch, and re-target to 4.17 ?

Done

thanks @vdombrovski

@blueorangutan package

[blueorangutan]

@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6090

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6692)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41047 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7587-t6692-kvm-centos7.zip
Smoke tests completed. 98 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_deploy_vm_with_extraconfig_kvm	Error	1.16	test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm	Error	1.14	test_deploy_vm_extra_config_data.py
test_08_upgrade_kubernetes_ha_cluster	Failure	578.13	test_kubernetes_clusters.py
test_02_deploy_vm_on_specific_cluster	Error	1.14	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	Error	1.17	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	Error	0.15	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	Error	0.12	test_vm_deployment_planner.py

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6267

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6766)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37771 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7587-t6766-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_deploy_vm_with_extraconfig_kvm	Error	1.14	test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm	Error	0.12	test_deploy_vm_extra_config_data.py
test_02_deploy_vm_on_specific_cluster	Error	0.12	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	Error	1.14	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	Error	1.16	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	Error	1.14	test_vm_deployment_planner.py

[DaanHoogland]

clgtm

[DaanHoogland]

tested the config in a 4.18 system vm

[weizhouapache]

@vdombrovski
I did some testing but could not reproduce the issue.

I confirmed the old command does not work and verified the new command works.

root@r-13-VM:~# /bin/kill -HUP `cat /var/run/rsyslog.pid 2> /dev/null`

Usage:
 kill [options] <pid> [...]

Options:
 <pid> [...]            send signal to every <pid> listed
 -<signal>, -s, --signal <signal>
                        specify the <signal> to be sent
 -q, --queue <value>    integer value to be sent with the signal
 -l, --list=[<signal>]  list all signal names, or convert one to a name
 -L, --table            list all signal names in a nice table

 -h, --help     display this help and exit
 -V, --version  output version information and exit

For more details see kill(1).
root@r-13-VM:~# 
root@r-13-VM:~# ls /var/run/rsyslog.pid
ls: cannot access '/var/run/rsyslog.pid': No such file or directory


root@r-9061-VM:~# /usr/lib/rsyslog/rsyslog-rotate

since I have faced same issue before and fixed the issue by same command, I believe this should work.