Skip to content

Conversation

@vishesh92
Copy link
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #7860 (881cc5f) into main (0204377) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7860   +/-   ##
=========================================
  Coverage     14.38%   14.38%           
- Complexity    10074    10075    +1     
=========================================
  Files          2747     2747           
  Lines        258922   258922           
  Branches      40318    40318           
=========================================
+ Hits          37246    37253    +7     
+ Misses       216867   216854   -13     
- Partials       4809     4815    +6     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6756

Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - didn't check all code - if it passes, all well

@DaanHoogland DaanHoogland reopened this Aug 14, 2023
@DaanHoogland DaanHoogland merged commit fe70f4d into apache:main Aug 16, 2023
@DaanHoogland DaanHoogland deleted the remove-powermock-services branch August 16, 2023 07:05
DaanHoogland added a commit to DaanHoogland/cloudstack that referenced this pull request Aug 24, 2023
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants