Fix: check root disk offering tagged limits during VM deploy

[vishesh92]

Description

This PR fixes a scenario in tagged limits checking. When user provides overriderootdiskoffering during deployVirtualMachine, the limits for this root disk aren't checked.

Steps to reproduce

Can be reproduced in Simulator. Begin by setting up a new Simulator zone, ready to deploy VMs.

1. create a test domain and account
2. create an NFS storage pool with a tag, e.g. "fast"
3. enable resource.limit.storage.tags for "fast" storage
4. create a disk offering with custom size, and storage tag "fast"
5. set primary storage limit for test domain and storage tag "fast", e.g. 5 GiB limit
6. launch a VM, using override root disk offering pointing to the "fast" offering, and size that goes beyond user's "fast" limit.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Applied this patched and tried to reproduce the issue with different scenarios.

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.34%. Comparing base (93f3182) to head (258fdec).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #8871       +/-   ##
============================================
- Coverage     32.17%   4.34%   -27.84%     
============================================
  Files          5045     361     -4684     
  Lines        351302   29004   -322298     
  Branches      50437    5092    -45345     
============================================
- Hits         113046    1260   -111786     
+ Misses       223069   27604   -195465     
+ Partials      15187     140    -15047     

Flag	Coverage Δ
simulator-marvin-tests	?
uitests	4.34% <ø> (?)
unit-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 29.10%. Comparing base (93f3182) to head (258fdec).

Files	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	81.81%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8871      +/-   ##
============================================
- Coverage     33.38%   29.10%   -4.28%     
+ Complexity    34061    31545    -2516     
============================================
  Files          5045     5406     +361     
  Lines        351302   380310   +29008     
  Branches      50437    55531    +5094     
============================================
- Hits         117289   110706    -6583     
- Misses       218439   254776   +36337     
+ Partials      15574    14828     -746     

Flag	Coverage Δ
simulator-marvin-tests	22.01% <81.81%> (-2.93%)	⬇️
uitests	4.34% <ø> (?)
unit-tests	16.87% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9132

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9672)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51601 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8871-t9672-kvm-centos7.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_enableHumanReadableLogs	Error	0.24	test_human_readable_logs.py

[borisstoyanov]

LGTM, manually tested it